Flexible I/O Tester development
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: vincentfu@gmail.com, fio@vger.kernel.org
Cc: Vincent Fu <vincent.fu@wdc.com>
Subject: Re: [PATCH 2/2] init: force threads when checking overlap in offload mode
Date: Tue, 16 Oct 2018 09:29:06 -0600	[thread overview]
Message-ID: <1a792daa-4327-1a4e-48df-4c691630c834@kernel.dk> (raw)
In-Reply-To: <20181016152650.7784-3-vincentfu@gmail.com>

On 10/16/18 9:26 AM, vincentfu@gmail.com wrote:
> From: Vincent Fu <vincent.fu@wdc.com>
> 
> serialize_overlap combined with io_submit_mode=offload requires
> threads. Print a warning and force the use of threads if the user
> did not specify threads.

Why does it require threads? Is it because of the use of a pthread
mutex? If so, that should just be a fio mutex instead, and you would
not have this restrictions (on most platforms, at least).

-- 
Jens Axboe



  reply	other threads:[~2018-10-16 15:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-16 15:26 [PATCH 0/2] cross-job overlap patches vincentfu
2018-10-16 15:26 ` [PATCH 1/2] serialize_overlap: document locking for cross-job overlap checking vincentfu
2018-10-16 15:26 ` [PATCH 2/2] init: force threads when checking overlap in offload mode vincentfu
2018-10-16 15:29   ` Jens Axboe [this message]
2018-10-16 15:33     ` Vincent Fu
2018-10-16 15:41       ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1a792daa-4327-1a4e-48df-4c691630c834@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=fio@vger.kernel.org \
    --cc=vincent.fu@wdc.com \
    --cc=vincentfu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox