Flexible I/O Tester development
 help / color / mirror / Atom feed
From: vincentfu@gmail.com
To: axboe@kernel.dk, fio@vger.kernel.org
Cc: Vincent Fu <vincent.fu@wdc.com>
Subject: [PATCH 2/2] init: force threads when checking overlap in offload mode
Date: Tue, 16 Oct 2018 11:26:50 -0400	[thread overview]
Message-ID: <20181016152650.7784-3-vincentfu@gmail.com> (raw)
In-Reply-To: <20181016152650.7784-1-vincentfu@gmail.com>

From: Vincent Fu <vincent.fu@wdc.com>

serialize_overlap combined with io_submit_mode=offload requires
threads. Print a warning and force the use of threads if the user
did not specify threads.
---
 init.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/init.c b/init.c
index a2b70c4a..224eb8ab 100644
--- a/init.c
+++ b/init.c
@@ -751,6 +751,14 @@ static int fixup_options(struct thread_data *td)
 	    o->io_submit_mode != IO_MODE_OFFLOAD)
 		o->serialize_overlap = 0;
 
+	if (o->serialize_overlap && o->io_submit_mode == IO_MODE_OFFLOAD && !o->use_thread) {
+		o->use_thread = 1;
+		log_info("fio: threads must be used when overlap checking is"
+			 " enabled in offload mode. Use the 'thread' option"
+			 " to get rid of this warning.\n");
+		ret |= warnings_fatal;
+	}
+
 	if (o->nr_files > td->files_index)
 		o->nr_files = td->files_index;
 
-- 
2.17.1



  parent reply	other threads:[~2018-10-16 15:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-16 15:26 [PATCH 0/2] cross-job overlap patches vincentfu
2018-10-16 15:26 ` [PATCH 1/2] serialize_overlap: document locking for cross-job overlap checking vincentfu
2018-10-16 15:26 ` vincentfu [this message]
2018-10-16 15:29   ` [PATCH 2/2] init: force threads when checking overlap in offload mode Jens Axboe
2018-10-16 15:33     ` Vincent Fu
2018-10-16 15:41       ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181016152650.7784-3-vincentfu@gmail.com \
    --to=vincentfu@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=fio@vger.kernel.org \
    --cc=vincent.fu@wdc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox