Re: "directory=" option not working??

[Jens Axboe <jens.axboe@oracle.com>]

On Sun, Apr 26 2009, Jens Axboe wrote:
> On Sat, Apr 25 2009, John Cagle wrote:
> > More info:  It looks like the [global] filename is not affected by the
> > [global] directory, but if you move the filename down into a job
> > section, it will get the directory name prepended...
> 
> Ah, good catch! Fio does do sorting, but not across sections. Weird that
> in then fails for global, I'll take a look at this tomorrow.

Not sure what happened there, but this will make it work. The case that
will still not work is this:

[global]
...
filename=foo

[job]
directory=/bar

I'll commit this patch and consider a way to fix the above.


diff --git a/options.c b/options.c
index 21de222..9267f79 100644
--- a/options.c
+++ b/options.c
@@ -605,7 +605,7 @@ static struct fio_option options[] = {
 		.type	= FIO_OPT_STR_STORE,
 		.off1	= td_var_offset(filename),
 		.cb	= str_filename_cb,
-		.prio	= 1, /* must come before "directory" */
+		.prio	= -1, /* must come after "directory" */
 		.help	= "File(s) to use for the workload",
 	},
 	{

-- 
Jens Axboe