"directory=" option not working??

"directory=" option not working??

[John Cagle]

I just tried the new ssd-test config file, and it uses a "directory="
option in the global section.

I specify "directory=/mnt" but it doesn't work.  I have an SSD mounted
at /mnt, but the files created by fio keep appearing in the cwd.

Can someone double check this on their system?  I'm working with the
latest source of fio, building it on Ubuntu x86_64.

John

Re: "directory=" option not working??

[John Cagle]

More info:  It looks like the [global] filename is not affected by the
[global] directory, but if you move the filename down into a job
section, it will get the directory name prepended...

John

On Sat, Apr 25, 2009 at 9:38 PM, John Cagle <jcagle@gmail.com> wrote:
> I just tried the new ssd-test config file, and it uses a "directory="
> option in the global section.
>
> I specify "directory=/mnt" but it doesn't work. �I have an SSD mounted
> at /mnt, but the files created by fio keep appearing in the cwd.
>
> Can someone double check this on their system? �I'm working with the
> latest source of fio, building it on Ubuntu x86_64.
>
> John

Re: "directory=" option not working??

[Jens Axboe]

On Sat, Apr 25 2009, John Cagle wrote:
> More info:  It looks like the [global] filename is not affected by the
> [global] directory, but if you move the filename down into a job
> section, it will get the directory name prepended...

Ah, good catch! Fio does do sorting, but not across sections. Weird that
in then fails for global, I'll take a look at this tomorrow.

> 
> John
> 
> On Sat, Apr 25, 2009 at 9:38 PM, John Cagle <jcagle@gmail.com> wrote:
> > I just tried the new ssd-test config file, and it uses a "directory="
> > option in the global section.
> >
> > I specify "directory=/mnt" but it doesn't work. �I have an SSD mounted
> > at /mnt, but the files created by fio keep appearing in the cwd.
> >
> > Can someone double check this on their system? �I'm working with the
> > latest source of fio, building it on Ubuntu x86_64.
> >
> > John
> --
> To unsubscribe from this list: send the line "unsubscribe fio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Jens Axboe

Re: "directory=" option not working??

[Jens Axboe]

On Sun, Apr 26 2009, Jens Axboe wrote:
> On Sat, Apr 25 2009, John Cagle wrote:
> > More info:  It looks like the [global] filename is not affected by the
> > [global] directory, but if you move the filename down into a job
> > section, it will get the directory name prepended...
> 
> Ah, good catch! Fio does do sorting, but not across sections. Weird that
> in then fails for global, I'll take a look at this tomorrow.

Not sure what happened there, but this will make it work. The case that
will still not work is this:

[global]
...
filename=foo

[job]
directory=/bar

I'll commit this patch and consider a way to fix the above.


diff --git a/options.c b/options.c
index 21de222..9267f79 100644
--- a/options.c
+++ b/options.c
@@ -605,7 +605,7 @@ static struct fio_option options[] = {
 		.type	= FIO_OPT_STR_STORE,
 		.off1	= td_var_offset(filename),
 		.cb	= str_filename_cb,
-		.prio	= 1, /* must come before "directory" */
+		.prio	= -1, /* must come after "directory" */
 		.help	= "File(s) to use for the workload",
 	},
 	{

-- 
Jens Axboe