Flexible I/O Tester development
 help / color / mirror / Atom feed
* How to control the number of random I/O's acrossing the whole file/device?
@ 2013-08-06 23:19 Jiahua
  2013-08-07 18:57 ` Jiahua
  0 siblings, 1 reply; 7+ messages in thread
From: Jiahua @ 2013-08-06 23:19 UTC (permalink / raw)
  To: fio

Hi all,

What I want is to touch a file/device randomly but up to a given
number of times. I tried the "size=" option but it also limits the
file size. Is there a way to do that instead of time_based, which is
approximate to my requirement?

Thanks,
Jiahua

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: How to control the number of random I/O's acrossing the whole file/device?
  2013-08-06 23:19 How to control the number of random I/O's acrossing the whole file/device? Jiahua
@ 2013-08-07 18:57 ` Jiahua
  2013-08-08 20:54   ` Jens Axboe
  0 siblings, 1 reply; 7+ messages in thread
From: Jiahua @ 2013-08-07 18:57 UTC (permalink / raw)
  To: fio

Sorry to bother you again! Can anyone shed some light here? Or can you
give a pointer into the code where I should look at to implement the
feature I want?

Thanks,
Jiahua

On Tue, Aug 6, 2013 at 4:19 PM, Jiahua <jiahua@gmail.com> wrote:
> Hi all,
>
> What I want is to touch a file/device randomly but up to a given
> number of times. I tried the "size=" option but it also limits the
> file size. Is there a way to do that instead of time_based, which is
> approximate to my requirement?
>
> Thanks,
> Jiahua

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: How to control the number of random I/O's acrossing the whole file/device?
  2013-08-07 18:57 ` Jiahua
@ 2013-08-08 20:54   ` Jens Axboe
  2013-08-09 18:19     ` Jiahua
  0 siblings, 1 reply; 7+ messages in thread
From: Jens Axboe @ 2013-08-08 20:54 UTC (permalink / raw)
  To: jiahua; +Cc: fio

On 08/07/2013 12:57 PM, Jiahua wrote:
> Sorry to bother you again! Can anyone shed some light here? Or can you
> give a pointer into the code where I should look at to implement the
> feature I want?
> 
> Thanks,
> Jiahua
> 
> On Tue, Aug 6, 2013 at 4:19 PM, Jiahua <jiahua@gmail.com> wrote:
>> Hi all,
>>
>> What I want is to touch a file/device randomly but up to a given
>> number of times. I tried the "size=" option but it also limits the
>> file size. Is there a way to do that instead of time_based, which is
>> approximate to my requirement?

Not sure what you as asking here. size= will generally specify the
region that fio will operate on. If you want to touch it multiple times,
you could do time_based and/or loops. The region will still be governed
by size= (or default to the existing total size of the file/device, if
not given).

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: How to control the number of random I/O's acrossing the whole file/device?
  2013-08-08 20:54   ` Jens Axboe
@ 2013-08-09 18:19     ` Jiahua
  2013-08-09 18:51       ` Jens Axboe
  0 siblings, 1 reply; 7+ messages in thread
From: Jiahua @ 2013-08-09 18:19 UTC (permalink / raw)
  To: Jens Axboe; +Cc: fio

I have a 1TB disk and try to do a fixed number, say 1000, random 4KB
I/O's cross the whole disk. If I use size=4MB, I can only touch the
first 4MB range of the disk instead of the whole disk range. If I set
size as 1TB, it will do much more than 1000 I/O's and run too long. As
for time_based, it is not ideal since I cannot control the I/O number
precisely.

On Thu, Aug 8, 2013 at 1:54 PM, Jens Axboe <axboe@kernel.dk> wrote:
> On 08/07/2013 12:57 PM, Jiahua wrote:
>> Sorry to bother you again! Can anyone shed some light here? Or can you
>> give a pointer into the code where I should look at to implement the
>> feature I want?
>>
>> Thanks,
>> Jiahua
>>
>> On Tue, Aug 6, 2013 at 4:19 PM, Jiahua <jiahua@gmail.com> wrote:
>>> Hi all,
>>>
>>> What I want is to touch a file/device randomly but up to a given
>>> number of times. I tried the "size=" option but it also limits the
>>> file size. Is there a way to do that instead of time_based, which is
>>> approximate to my requirement?
>
> Not sure what you as asking here. size= will generally specify the
> region that fio will operate on. If you want to touch it multiple times,
> you could do time_based and/or loops. The region will still be governed
> by size= (or default to the existing total size of the file/device, if
> not given).
>
> --
> Jens Axboe
>


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: How to control the number of random I/O's acrossing the whole file/device?
  2013-08-09 18:19     ` Jiahua
@ 2013-08-09 18:51       ` Jens Axboe
  2013-08-13  5:23         ` Jiahua
  0 siblings, 1 reply; 7+ messages in thread
From: Jens Axboe @ 2013-08-09 18:51 UTC (permalink / raw)
  To: Jiahua; +Cc: fio

On Fri, Aug 09 2013, Jiahua wrote:
> I have a 1TB disk and try to do a fixed number, say 1000, random 4KB
> I/O's cross the whole disk. If I use size=4MB, I can only touch the
> first 4MB range of the disk instead of the whole disk range. If I set
> size as 1TB, it will do much more than 1000 I/O's and run too long. As
> for time_based, it is not ideal since I cannot control the I/O number
> precisely.

Ah, I see what you mean. Try and patch the below in, then set
number_ios=1000 and see if it does what you want.

diff --git a/cconv.c b/cconv.c
index 8e7c69e..21e3a51 100644
--- a/cconv.c
+++ b/cconv.c
@@ -146,6 +146,7 @@ void convert_thread_options_to_cpu(struct thread_options *o,
 	o->zone_skip = le64_to_cpu(top->zone_skip);
 	o->lockmem = le64_to_cpu(top->lockmem);
 	o->offset_increment = le64_to_cpu(top->offset_increment);
+	o->number_ios = le64_to_cpu(top->number_ios);
 
 	o->overwrite = le32_to_cpu(top->overwrite);
 	o->bw_avg_time = le32_to_cpu(top->bw_avg_time);
@@ -394,6 +395,7 @@ void convert_thread_options_to_net(struct thread_options_pack *top,
 	top->start_offset = __cpu_to_le64(o->start_offset);
 	top->trim_backlog = __cpu_to_le64(o->trim_backlog);
 	top->offset_increment = __cpu_to_le64(o->offset_increment);
+	top->number_ios = __cpu_to_le64(o->number_ios);
 
 	for (i = 0; i < FIO_IO_U_LIST_MAX_LEN; i++)
 		top->percentile_list[i].u.i = __cpu_to_le64(fio_double_to_uint64(o->percentile_list[i].u.f));
diff --git a/io_u.c b/io_u.c
index a35aafd..c50a17d 100644
--- a/io_u.c
+++ b/io_u.c
@@ -1413,6 +1413,9 @@ static void account_io_completion(struct thread_data *td, struct io_u *io_u,
 		add_bw_sample(td, idx, bytes, &icd->time);
 
 	add_iops_sample(td, idx, bytes, &icd->time);
+
+	if (td->o.number_ios && !--td->o.number_ios)
+		td->done = 1;
 }
 
 static long long usec_for_io(struct thread_data *td, enum fio_ddir ddir)
diff --git a/options.c b/options.c
index 1816d0b..caf89d3 100644
--- a/options.c
+++ b/options.c
@@ -1483,6 +1483,16 @@ struct fio_option fio_options[FIO_MAX_OPTS] = {
 		.group	= FIO_OPT_G_INVALID,
 	},
 	{
+		.name	= "number_ios",
+		.lname	= "Number of IOs to perform",
+		.type	= FIO_OPT_STR_VAL,
+		.off1	= td_var_offset(number_ios),
+		.help	= "Force job completion of this number of IOs",
+		.def	= "0",
+		.category = FIO_OPT_C_IO,
+		.group	= FIO_OPT_G_INVALID,
+	},
+	{
 		.name	= "bs",
 		.lname	= "Block size",
 		.alias	= "blocksize",
diff --git a/thread_options.h b/thread_options.h
index eaafaee..3f345c5 100644
--- a/thread_options.h
+++ b/thread_options.h
@@ -236,6 +236,7 @@ struct thread_options {
 	unsigned int flow_sleep;
 
 	unsigned long long offset_increment;
+	unsigned long long number_ios;
 
 	unsigned int sync_file_range;
 };
@@ -440,6 +441,7 @@ struct thread_options_pack {
 	uint32_t flow_sleep;
 
 	uint64_t offset_increment;
+	uint64_t number_ios;
 
 	uint32_t sync_file_range;
 } __attribute__((packed));

-- 
Jens Axboe


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: How to control the number of random I/O's acrossing the whole file/device?
  2013-08-09 18:51       ` Jens Axboe
@ 2013-08-13  5:23         ` Jiahua
  2013-08-13 14:41           ` Jens Axboe
  0 siblings, 1 reply; 7+ messages in thread
From: Jiahua @ 2013-08-13  5:23 UTC (permalink / raw)
  To: Jens Axboe; +Cc: fio

It works. Thank you very much!

On Fri, Aug 9, 2013 at 11:51 AM, Jens Axboe <axboe@kernel.dk> wrote:
> On Fri, Aug 09 2013, Jiahua wrote:
>> I have a 1TB disk and try to do a fixed number, say 1000, random 4KB
>> I/O's cross the whole disk. If I use size=4MB, I can only touch the
>> first 4MB range of the disk instead of the whole disk range. If I set
>> size as 1TB, it will do much more than 1000 I/O's and run too long. As
>> for time_based, it is not ideal since I cannot control the I/O number
>> precisely.
>
> Ah, I see what you mean. Try and patch the below in, then set
> number_ios=1000 and see if it does what you want.
>
> diff --git a/cconv.c b/cconv.c
> index 8e7c69e..21e3a51 100644
> --- a/cconv.c
> +++ b/cconv.c
> @@ -146,6 +146,7 @@ void convert_thread_options_to_cpu(struct thread_options *o,
>         o->zone_skip = le64_to_cpu(top->zone_skip);
>         o->lockmem = le64_to_cpu(top->lockmem);
>         o->offset_increment = le64_to_cpu(top->offset_increment);
> +       o->number_ios = le64_to_cpu(top->number_ios);
>
>         o->overwrite = le32_to_cpu(top->overwrite);
>         o->bw_avg_time = le32_to_cpu(top->bw_avg_time);
> @@ -394,6 +395,7 @@ void convert_thread_options_to_net(struct thread_options_pack *top,
>         top->start_offset = __cpu_to_le64(o->start_offset);
>         top->trim_backlog = __cpu_to_le64(o->trim_backlog);
>         top->offset_increment = __cpu_to_le64(o->offset_increment);
> +       top->number_ios = __cpu_to_le64(o->number_ios);
>
>         for (i = 0; i < FIO_IO_U_LIST_MAX_LEN; i++)
>                 top->percentile_list[i].u.i = __cpu_to_le64(fio_double_to_uint64(o->percentile_list[i].u.f));
> diff --git a/io_u.c b/io_u.c
> index a35aafd..c50a17d 100644
> --- a/io_u.c
> +++ b/io_u.c
> @@ -1413,6 +1413,9 @@ static void account_io_completion(struct thread_data *td, struct io_u *io_u,
>                 add_bw_sample(td, idx, bytes, &icd->time);
>
>         add_iops_sample(td, idx, bytes, &icd->time);
> +
> +       if (td->o.number_ios && !--td->o.number_ios)
> +               td->done = 1;
>  }
>
>  static long long usec_for_io(struct thread_data *td, enum fio_ddir ddir)
> diff --git a/options.c b/options.c
> index 1816d0b..caf89d3 100644
> --- a/options.c
> +++ b/options.c
> @@ -1483,6 +1483,16 @@ struct fio_option fio_options[FIO_MAX_OPTS] = {
>                 .group  = FIO_OPT_G_INVALID,
>         },
>         {
> +               .name   = "number_ios",
> +               .lname  = "Number of IOs to perform",
> +               .type   = FIO_OPT_STR_VAL,
> +               .off1   = td_var_offset(number_ios),
> +               .help   = "Force job completion of this number of IOs",
> +               .def    = "0",
> +               .category = FIO_OPT_C_IO,
> +               .group  = FIO_OPT_G_INVALID,
> +       },
> +       {
>                 .name   = "bs",
>                 .lname  = "Block size",
>                 .alias  = "blocksize",
> diff --git a/thread_options.h b/thread_options.h
> index eaafaee..3f345c5 100644
> --- a/thread_options.h
> +++ b/thread_options.h
> @@ -236,6 +236,7 @@ struct thread_options {
>         unsigned int flow_sleep;
>
>         unsigned long long offset_increment;
> +       unsigned long long number_ios;
>
>         unsigned int sync_file_range;
>  };
> @@ -440,6 +441,7 @@ struct thread_options_pack {
>         uint32_t flow_sleep;
>
>         uint64_t offset_increment;
> +       uint64_t number_ios;
>
>         uint32_t sync_file_range;
>  } __attribute__((packed));
>
> --
> Jens Axboe
>


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: How to control the number of random I/O's acrossing the whole file/device?
  2013-08-13  5:23         ` Jiahua
@ 2013-08-13 14:41           ` Jens Axboe
  0 siblings, 0 replies; 7+ messages in thread
From: Jens Axboe @ 2013-08-13 14:41 UTC (permalink / raw)
  To: Jiahua; +Cc: fio

On Mon, Aug 12 2013, Jiahua wrote:
> It works. Thank you very much!

It's included in the current -git versions of fio, so will be part of
2.1.3 final.

-- 
Jens Axboe



^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2013-08-13 14:41 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-06 23:19 How to control the number of random I/O's acrossing the whole file/device? Jiahua
2013-08-07 18:57 ` Jiahua
2013-08-08 20:54   ` Jens Axboe
2013-08-09 18:19     ` Jiahua
2013-08-09 18:51       ` Jens Axboe
2013-08-13  5:23         ` Jiahua
2013-08-13 14:41           ` Jens Axboe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox