From: vincentfu@gmail.com
To: axboe@kernel.dk, fio@vger.kernel.org
Cc: Vincent Fu <vincent.fu@wdc.com>
Subject: [PATCH 9/9] t/run-fio-tests: relax acceptance criterion for t0011
Date: Tue, 10 Dec 2019 12:54:42 -0500 [thread overview]
Message-ID: <20191210175442.2975-10-vincentfu@gmail.com> (raw)
In-Reply-To: <20191210175442.2975-1-vincentfu@gmail.com>
From: Vincent Fu <vincent.fu@wdc.com>
I saw a handful of benign failures for t0011 when run on
travis/appveyor. This patch allows the test to still pass with a
measured IOPS of 998 to 1002 and adds a debug print for the value
actually observed.
---
t/run-fio-tests.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/t/run-fio-tests.py b/t/run-fio-tests.py
index 4c7cc3a4..a0a1e8fa 100755
--- a/t/run-fio-tests.py
+++ b/t/run-fio-tests.py
@@ -406,9 +406,10 @@ class FioJobTest_t0011(FioJobTest):
iops1 = self.json_data['jobs'][0]['read']['iops']
iops2 = self.json_data['jobs'][1]['read']['iops']
ratio = iops2 / iops1
+ logging.debug("Test %d: iops1: %f" % (self.testnum, iops1))
logging.debug("Test %d: ratio: %f" % (self.testnum, ratio))
- if iops1 < 999 or iops1 > 1001:
+ if iops1 < 998 or iops1 > 1002:
self.failure_reason = "{0} iops value mismatch,".format(self.failure_reason)
self.passed = False
--
2.17.1
next prev parent reply other threads:[~2019-12-10 17:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 17:54 [PATCH 0/9] testing patches vincentfu
2019-12-10 17:54 ` [PATCH 1/9] .gitignore: ignore zbd test output files vincentfu
2019-12-10 17:54 ` [PATCH 2/9] t/run-fio-tests: a few small improvements vincentfu
2019-12-10 17:54 ` [PATCH 3/9] t/run-fio-tests: detect requirements and skip tests accordingly vincentfu
2019-12-10 17:54 ` [PATCH 4/9] t/run-fio-tests: improve Windows support vincentfu
2019-12-10 17:54 ` [PATCH 5/9] t/run-fio-tests: identify test id for debug messages vincentfu
2019-12-10 17:54 ` [PATCH 6/9] t/steadystate_tests: use null ioengine for tests vincentfu
2019-12-10 17:54 ` [PATCH 7/9] .travis.yml: run t/run-fio.tests.py as part of build vincentfu
2019-12-10 17:54 ` [PATCH 8/9] .appveyor.yml: run run-fio-tests.py vincentfu
2019-12-10 17:54 ` vincentfu [this message]
2019-12-10 21:32 ` [PATCH 0/9] testing patches Sitsofe Wheeler
2019-12-11 19:53 ` Vincent Fu
2019-12-11 19:57 ` Jens Axboe
2019-12-11 20:10 ` Vincent Fu
2019-12-12 3:54 ` Jens Axboe
2019-12-12 8:37 ` Sitsofe Wheeler
2019-12-16 22:13 ` Jens Axboe
2019-12-16 22:42 ` Vincent Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191210175442.2975-10-vincentfu@gmail.com \
--to=vincentfu@gmail.com \
--cc=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=vincent.fu@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox