From: Vincent Fu <vincentfu@gmail.com>
To: Sitsofe Wheeler <sitsofe@gmail.com>
Cc: Jens Axboe <axboe@kernel.dk>, fio <fio@vger.kernel.org>,
Vincent Fu <vincent.fu@wdc.com>
Subject: Re: [PATCH 0/9] testing patches
Date: Wed, 11 Dec 2019 14:53:24 -0500 [thread overview]
Message-ID: <191fa593-aecc-a077-c24f-980f6d8280e0@gmail.com> (raw)
In-Reply-To: <CALjAwxi-nfeunNEOuhbjF8L-0LhmmHZ=exRBAJ0V+EQi0ep37Q@mail.gmail.com>
On 12/10/19 4:32 PM, Sitsofe Wheeler wrote:
> On Tue, 10 Dec 2019 at 17:56, <vincentfu@gmail.com> wrote:
>>
>> From: Vincent Fu <vincent.fu@wdc.com>
>>
>> Jens, please consider this series of patches related to testing.
>>
>> The patches improve t/run-fio-tests.py in various ways, most prominently
>> adding support for Windows and macOS.
>>
>> Also included are travis and appveyor patches that add run-fio-tests.py
>> as a step. Currently both the travis and appveyor build processes
>> complete in less than four minutes. Adding run-fio-tests.py increases
>> this to about 20 minutes for travis and 14 minutes for appveyor.
>
> In general I think this work is fantastic and much needed (you can
> search through the fio commit logs using "git log --grep 'size='" to
> find jobs files that have caused issues in the past and may be worth
> turning into tests at some point). However, I think making the builds
> so slow may be a disadvantage rather than a benefit. I agree with
> nearly all the patch set bar running this by default with
> travis/appveyor...
>
Many thanks for the feedback, Sitsofe. I agree that the build times are
uncomfortably long, but since I had done the work I thought I would
offer the patches to Jens.
Jens, what do you think? Would you like me to re-send the patch series
without the appveyor and travis changes?
next prev parent reply other threads:[~2019-12-11 19:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 17:54 [PATCH 0/9] testing patches vincentfu
2019-12-10 17:54 ` [PATCH 1/9] .gitignore: ignore zbd test output files vincentfu
2019-12-10 17:54 ` [PATCH 2/9] t/run-fio-tests: a few small improvements vincentfu
2019-12-10 17:54 ` [PATCH 3/9] t/run-fio-tests: detect requirements and skip tests accordingly vincentfu
2019-12-10 17:54 ` [PATCH 4/9] t/run-fio-tests: improve Windows support vincentfu
2019-12-10 17:54 ` [PATCH 5/9] t/run-fio-tests: identify test id for debug messages vincentfu
2019-12-10 17:54 ` [PATCH 6/9] t/steadystate_tests: use null ioengine for tests vincentfu
2019-12-10 17:54 ` [PATCH 7/9] .travis.yml: run t/run-fio.tests.py as part of build vincentfu
2019-12-10 17:54 ` [PATCH 8/9] .appveyor.yml: run run-fio-tests.py vincentfu
2019-12-10 17:54 ` [PATCH 9/9] t/run-fio-tests: relax acceptance criterion for t0011 vincentfu
2019-12-10 21:32 ` [PATCH 0/9] testing patches Sitsofe Wheeler
2019-12-11 19:53 ` Vincent Fu [this message]
2019-12-11 19:57 ` Jens Axboe
2019-12-11 20:10 ` Vincent Fu
2019-12-12 3:54 ` Jens Axboe
2019-12-12 8:37 ` Sitsofe Wheeler
2019-12-16 22:13 ` Jens Axboe
2019-12-16 22:42 ` Vincent Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=191fa593-aecc-a077-c24f-980f6d8280e0@gmail.com \
--to=vincentfu@gmail.com \
--cc=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=sitsofe@gmail.com \
--cc=vincent.fu@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox