* fix 1000 vs kb_base confusion in show_run_stats.
@ 2010-06-23 2:37 YAMAMOTO Takashi
2010-06-23 12:48 ` Jens Axboe
0 siblings, 1 reply; 3+ messages in thread
From: YAMAMOTO Takashi @ 2010-06-23 2:37 UTC (permalink / raw)
To: fio
hi,
please apply the following patch.
YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi <yamamoto@valinux.co.jp>
commit 6225a65ed63f82ae30258d3e0d45e179a645ca05
Author: YAMAMOTO Takashi <yamamoto@valinux.co.jp>
Date: Wed Jun 23 11:36:01 2010 +0900
fix 1000 vs kb_base confusion in show_run_stats.
diff --git a/stat.c b/stat.c
index 9d1f66a..143325a 100644
--- a/stat.c
+++ b/stat.c
@@ -635,9 +635,9 @@ void show_run_stats(void)
max_run[1] = rs->max_run[1];
if (rs->max_run[0])
- rs->agg[0] = (rs->io_kb[0] * 1000) / max_run[0];
+ rs->agg[0] = (rs->io_kb[0] * rs->kb_base) / max_run[0];
if (rs->max_run[1])
- rs->agg[1] = (rs->io_kb[1] * 1000) / max_run[1];
+ rs->agg[1] = (rs->io_kb[1] * rs->kb_base) / max_run[1];
}
/*
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: fix 1000 vs kb_base confusion in show_run_stats.
2010-06-23 2:37 fix 1000 vs kb_base confusion in show_run_stats YAMAMOTO Takashi
@ 2010-06-23 12:48 ` Jens Axboe
2010-06-25 12:34 ` Jens Axboe
0 siblings, 1 reply; 3+ messages in thread
From: Jens Axboe @ 2010-06-23 12:48 UTC (permalink / raw)
To: YAMAMOTO Takashi; +Cc: fio
On 2010-06-23 04:37, YAMAMOTO Takashi wrote:
> hi,
>
> please apply the following patch.
>
> YAMAMOTO Takashi
Thanks, applied.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: fix 1000 vs kb_base confusion in show_run_stats.
2010-06-23 12:48 ` Jens Axboe
@ 2010-06-25 12:34 ` Jens Axboe
0 siblings, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2010-06-25 12:34 UTC (permalink / raw)
To: YAMAMOTO Takashi; +Cc: fio
On 2010-06-23 14:48, Jens Axboe wrote:
> On 2010-06-23 04:37, YAMAMOTO Takashi wrote:
>> hi,
>>
>> please apply the following patch.
>>
>> YAMAMOTO Takashi
>
> Thanks, applied.
On second though, this is wrong. The 1000 divisor is
for msec to sec, not from byte to kb.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-06-25 12:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-23 2:37 fix 1000 vs kb_base confusion in show_run_stats YAMAMOTO Takashi
2010-06-23 12:48 ` Jens Axboe
2010-06-25 12:34 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox