* Small cleanup patch
@ 2011-06-03 19:14 Steven Lang
2011-06-03 19:16 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Steven Lang @ 2011-06-03 19:14 UTC (permalink / raw)
To: fio; +Cc: jaxboe
The wrong ddir enum was being used here, which trips up compilers
which want to strictly check enum usage.
diff --git a/fio.c b/fio.c
index 76c6ebd..34956e9 100644
--- a/fio.c
+++ b/fio.c
@@ -180,7 +180,7 @@ static void set_sig_handlers(void)
* Check if we are above the minimum rate given.
*/
static int __check_min_rate(struct thread_data *td, struct timeval *now,
- enum td_ddir ddir)
+ enum fio_ddir ddir)
{
unsigned long long bytes = 0;
unsigned long iops = 0;
--
- Steven
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: Small cleanup patch
2011-06-03 19:14 Small cleanup patch Steven Lang
@ 2011-06-03 19:16 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2011-06-03 19:16 UTC (permalink / raw)
To: Steven Lang; +Cc: fio@vger.kernel.org
On 2011-06-03 21:14, Steven Lang wrote:
> The wrong ddir enum was being used here, which trips up compilers
> which want to strictly check enum usage.
>
> diff --git a/fio.c b/fio.c
> index 76c6ebd..34956e9 100644
> --- a/fio.c
> +++ b/fio.c
> @@ -180,7 +180,7 @@ static void set_sig_handlers(void)
> * Check if we are above the minimum rate given.
> */
> static int __check_min_rate(struct thread_data *td, struct timeval *now,
> - enum td_ddir ddir)
> + enum fio_ddir ddir)
> {
> unsigned long long bytes = 0;
> unsigned long iops = 0;
Oops, thanks and applied.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-06-03 19:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-03 19:14 Small cleanup patch Steven Lang
2011-06-03 19:16 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox