Flexible I/O Tester development
 help / color / mirror / Atom feed
From: Dave Engberg <dengberg@evernote.com>
To: fio@vger.kernel.org
Subject: bsrange doesn't accept separate read,write values
Date: Sat, 23 Jul 2011 11:53:57 -0700	[thread overview]
Message-ID: <4E2B18C5.3090602@evernote.com> (raw)

The 'bs' and 'bssplit' configuration variables accept separate numbers for read and write operations if you separate them with a comma. For example:
bssplit=1k/39:8k/50:64k/11,1k/29:8k/50:64k/21

The documentation for 'bsrange' says it works the same way, but if I try to specify two ranges with a comma, I get an error when I run the app. E.g. if I put this line in the configuration file:
bsrange=1k-16k,2k-32k

I get this error output:

fio: pid=26861, err=22/file:engines/sync.c:62, func=xfer, error=Invalid argument

Here's my attempt at a patch for this:


*** fio-1.57-orig/parse.c    2011-07-14 11:20:25.000000000 -0700
--- fio-1.57/parse.c    2011-07-23 11:38:12.000000000 -0700
***************
*** 453,458 ****
--- 453,464 ----

            strncpy(tmp, ptr, sizeof(tmp) - 1);

+         // Handle bsrange with separate read,write values:
+         p1 = strchr(tmp, ',');
+         if (p1) {
+           *p1 = '\0';
+         }
+
            p1 = strchr(tmp, '-');
            if (!p1) {
                p1 = strchr(tmp, ':');


             reply	other threads:[~2011-07-23 18:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-23 18:53 Dave Engberg [this message]
2011-07-23 18:59 ` bsrange doesn't accept separate read,write values Jens Axboe
2011-07-23 19:04   ` Dave Engberg
2011-07-23 19:05     ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E2B18C5.3090602@evernote.com \
    --to=dengberg@evernote.com \
    --cc=fio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox