From: Jens Axboe <axboe@kernel.dk>
To: Yu-ju Hong <yjhong@google.com>
Cc: fio@vger.kernel.org, Nauman Rafique <nauman@google.com>,
Eric Gouriou <egouriou@google.com>,
Yu-Ju Hong <yuju.hong@gmail.com>
Subject: Re: [PATCH] stats: Add a function to report completion latency percentiles
Date: Sat, 13 Aug 2011 00:56:22 +0200 [thread overview]
Message-ID: <4E45AF96.4070606@kernel.dk> (raw)
In-Reply-To: <1313175153-5355-1-git-send-email-yjhong@google.com>
On 2011-08-12 20:52, Yu-ju Hong wrote:
> This patch introduces two new options:
> 1) Specifying --clat_percentiles enables the reporting of
> completion latency percentiles.
> 2) --percentile_list allows the user to customize the
> list of percentiles to report.
Good feature, applied. The usage of done and !done for 'first' and
'curr' is a little odd, at least it could warrant a comment. But
otherwise looks good.
--
Jens Axboe
next prev parent reply other threads:[~2011-08-12 22:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-12 18:52 [PATCH] stats: Add a function to report completion latency percentiles Yu-ju Hong
2011-08-12 22:56 ` Jens Axboe [this message]
2011-08-15 3:56 ` Zhu Yanhai
2011-08-15 6:54 ` Jens Axboe
2011-08-15 6:59 ` Jens Axboe
2011-08-15 7:15 ` Zhu Yanhai
2011-08-15 7:16 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E45AF96.4070606@kernel.dk \
--to=axboe@kernel.dk \
--cc=egouriou@google.com \
--cc=fio@vger.kernel.org \
--cc=nauman@google.com \
--cc=yjhong@google.com \
--cc=yuju.hong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox