From: Jens Axboe <jaxboe@fusionio.com>
To: Zhu Yanhai <zhu.yanhai@gmail.com>
Cc: Yu-ju Hong <yjhong@google.com>,
fio@vger.kernel.org, Nauman Rafique <nauman@google.com>,
Eric Gouriou <egouriou@google.com>,
Yu-Ju Hong <yuju.hong@gmail.com>
Subject: Re: [PATCH] stats: Add a function to report completion latency percentiles
Date: Mon, 15 Aug 2011 08:59:37 +0200 [thread overview]
Message-ID: <4E48C3D9.4020000@fusionio.com> (raw)
In-Reply-To: <4E48C2C1.60307@kernel.dk>
On 2011-08-15 08:54, Jens Axboe wrote:
> On 2011-08-15 05:56, Zhu Yanhai wrote:
>> Hi,
>> This commit breaks the calculation of iops.
>> Before this commit, the iops from group_report is 1467, see below:
>>
>> chenyun@test023057.sqa.cm4 fio]$ sudo ./fio ~/iotest/readdev
>> thread16: (g=0): rw=randread, bs=4K-4K/4K-4K, ioengine=sync, iodepth=1
>> ...
>> thread16: (g=0): rw=randread, bs=4K-4K/4K-4K, ioengine=sync, iodepth=1
>> fio 1.57
>> Starting 10 threads
>> Jobs: 10 (f=10): [rrrrrrrrrr] [100.0% done] [5929K/0K /s] [1447 /0
>> iops] [eta 00m:00s]
>> thread16: (groupid=0, jobs=10): err= 0: pid=19538
>> read : io=176212KB, bw=5871.6KB/s, iops=1467 , runt= 30011msec
>> [cut here]
>>
>>
>> After this commit, the reported iops is 266, which is only one thread's output,
>> not group_reporting, see below:
>>
>> [chenyun@test023057.sqa.cm4 fio]$ sudo ./fio ~/iotest/readdev
>> thread16: (g=0): rw=randread, bs=4K-4K/4K-4K, ioengine=sync, iodepth=1
>> ...
>> thread16: (g=0): rw=randread, bs=4K-4K/4K-4K, ioengine=sync, iodepth=1
>> fio 1.57
>> Starting 10 threads
>> Jobs: 10 (f=10): [rrrrrrrrrr] [100.0% done] [6033K/0K /s] [1473 /0
>> iops] [eta 00m:00s]
>> thread16: (groupid=0, jobs=10): err= 0: pid=19692
>> read : io=351720KB, bw=1065.7KB/s, iops=266 , runt=330046msec
>> [cut here]
>
> The patch does indeed appear to have broken output for more than 1
> thread in general, even without group_reporting things are not right. It
> also crashes here for me now:
Zhu, does this work for you?
diff --git a/fio.h b/fio.h
index 6766351..c741162 100644
--- a/fio.h
+++ b/fio.h
@@ -217,7 +217,7 @@ struct thread_stat {
unsigned int io_u_complete[FIO_IO_U_MAP_NR];
unsigned int io_u_lat_u[FIO_IO_U_LAT_U_NR];
unsigned int io_u_lat_m[FIO_IO_U_LAT_M_NR];
- unsigned int io_u_plat [2][FIO_IO_U_PLAT_NR];
+ unsigned int io_u_plat[3][FIO_IO_U_PLAT_NR];
unsigned long total_io_u[3];
unsigned long short_io_u[3];
unsigned long total_submit;
--
Jens Axboe
next prev parent reply other threads:[~2011-08-15 6:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-12 18:52 [PATCH] stats: Add a function to report completion latency percentiles Yu-ju Hong
2011-08-12 22:56 ` Jens Axboe
2011-08-15 3:56 ` Zhu Yanhai
2011-08-15 6:54 ` Jens Axboe
2011-08-15 6:59 ` Jens Axboe [this message]
2011-08-15 7:15 ` Zhu Yanhai
2011-08-15 7:16 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E48C3D9.4020000@fusionio.com \
--to=jaxboe@fusionio.com \
--cc=egouriou@google.com \
--cc=fio@vger.kernel.org \
--cc=nauman@google.com \
--cc=yjhong@google.com \
--cc=yuju.hong@gmail.com \
--cc=zhu.yanhai@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox