From: Jens Axboe <axboe@kernel.dk>
To: Shrirang Phansalkar <sphansalkar@stec-inc.com>
Cc: "fio@vger.kernel.org" <fio@vger.kernel.org>,
Prasad Joshi <pjoshi@stec-inc.com>
Subject: Re: problem while executing fio on multiple disks
Date: Thu, 08 Sep 2011 13:32:52 +0200 [thread overview]
Message-ID: <4E68A7E4.2020005@kernel.dk> (raw)
In-Reply-To: <4E68A7C9.1020702@kernel.dk>
On 2011-09-08 13:32, Jens Axboe wrote:
> Hmm, I'm assuming the performance is about the same (whether run with
> this file, or separately)?
>
> Looks like the utilization is done prior to the job being started, hence
> you get ~100%, ~50%, and ~33%. So looks like just an accounting bug,
> I'll take a look at it.
Does this work? Completely untested...
diff --git a/fio.c b/fio.c
index 4514840..b492889 100644
--- a/fio.c
+++ b/fio.c
@@ -1502,10 +1502,8 @@ static void run_threads(void)
for_each_td(td, i) {
print_status_init(td->thread_number - 1);
- if (!td->o.create_serialize) {
- init_disk_util(td);
+ if (!td->o.create_serialize)
continue;
- }
/*
* do file setup here so it happens sequentially,
@@ -1533,8 +1531,6 @@ static void run_threads(void)
td_io_close_file(td, f);
}
}
-
- init_disk_util(td);
}
set_genesis_time();
@@ -1573,6 +1569,8 @@ static void run_threads(void)
break;
}
+ init_disk_util(td);
+
/*
* Set state to created. Thread will transition
* to TD_INITIALIZED when it's done setting up.
--
Jens Axboe
prev parent reply other threads:[~2011-09-08 11:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-08 9:55 problem while executing fio on multiple disks Shrirang Phansalkar
2011-09-08 11:32 ` Jens Axboe
2011-09-08 11:32 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E68A7E4.2020005@kernel.dk \
--to=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=pjoshi@stec-inc.com \
--cc=sphansalkar@stec-inc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox