* [PATCH] flow: Fixing uninitialized variable
@ 2012-02-22 2:31 Dan Ehrenberg
2012-02-22 10:49 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Dan Ehrenberg @ 2012-02-22 2:31 UTC (permalink / raw)
To: fio; +Cc: nauman, egouriou, tirea, Dan Ehrenberg
In the flow initialization code path, there was an uninitialized
variable that led to memory corruption in certain cases. This
patch should initialize the variable properly.
---
flow.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/flow.c b/flow.c
index e5c4a40..bf5eeec 100644
--- a/flow.c
+++ b/flow.c
@@ -36,7 +36,7 @@ int flow_threshold_exceeded(struct thread_data *td)
static struct fio_flow *flow_get(unsigned int id)
{
- struct fio_flow *flow;
+ struct fio_flow *flow = NULL;
struct flist_head *n;
fio_mutex_down(flow_lock);
--
1.7.7.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] flow: Fixing uninitialized variable
2012-02-22 2:31 [PATCH] flow: Fixing uninitialized variable Dan Ehrenberg
@ 2012-02-22 10:49 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2012-02-22 10:49 UTC (permalink / raw)
To: Dan Ehrenberg; +Cc: fio, nauman, egouriou, tirea
On 02/22/2012 03:31 AM, Dan Ehrenberg wrote:
> In the flow initialization code path, there was an uninitialized
> variable that led to memory corruption in certain cases. This
> patch should initialize the variable properly.
Thanks, I wonder how I missed that. Applied.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-02-22 10:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-22 2:31 [PATCH] flow: Fixing uninitialized variable Dan Ehrenberg
2012-02-22 10:49 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox