Windows & netio problems/bugreport

Windows & netio problems/bugreport

[Stefan Hübner]

Hello Bruce,

I just noticed a major bug in fio for windows (proven on W7 and WSS 2008R2).  It seems the netio-testing doesn't work at all a.t.m, even with elevated privileges.

C:\Program Files\fio\examples>..\fio.exe netio
receiver: (g=0): rw=read, bs=4K-4K/4K-4K, ioengine=net, iodepth=1
sender: (g=0): rw=write, bs=4K-4K/4K-4K, ioengine=net, iodepth=1
fio-2.0.9
Starting 2 threads
fio: pid=2644, err=1/file:engines/net.c:631, func=socket, error=No error
Jobs: 1 (f=0): [XW] [0.0% done] [0K/0K /s] [0 /0  iops] [eta 49710d:06h:19m:22s]
C:\Program Files\fio\examples>

This happened when testing the example "netio" taskfile.  I've written own taskfiles where I get the same error.

corresponding code:
static int fio_netio_setup_listen_inet(struct thread_data *td, short port)
{
        struct netio_data *nd = td->io_ops->data;
        struct netio_options *o = td->eo;
        int fd, opt, type;

        if (o->proto == FIO_TYPE_TCP)
                type = SOCK_STREAM;
        else
                type = SOCK_DGRAM;

-->     fd = socket(AF_INET, type, 0);
        if (fd < 0) {
                td_verror(td, errno, "socket");
                return 1;
        }
[...]

May this mean the "socket()" function needs to be used differently in Windows?  Can you put a "FixIt" on your ToDo-List for this?

all the best,
Stefan

Re: Windows & netio problems/bugreport

[Bruce Cran]

On 18/09/2012 11:30, Stefan Hübner wrote:
> I just noticed a major bug in fio for windows (proven on W7 and WSS 2008R2).  It seems the netio-testing doesn't work at all a.t.m, even with elevated privileges.

There were a few problems, which I'll fix for 2.0.10:

There was no call to WSAStartup().
inet_aton() wasn't implemented.
There was a NULL dereference bug in poll().

-- 
Bruce Cran

Re: Windows & netio problems/bugreport

[Jens Axboe]

On 2012-10-10 06:27, Bruce Cran wrote:
> On 18/09/2012 11:30, Stefan Hübner wrote:
>> I just noticed a major bug in fio for windows (proven on W7 and WSS 2008R2).  It seems the netio-testing doesn't work at all a.t.m, even with elevated privileges.
> 
> There were a few problems, which I'll fix for 2.0.10:
> 
> There was no call to WSAStartup().
> inet_aton() wasn't implemented.
> There was a NULL dereference bug in poll().

Bruce's patch has been integrated into the current -git version.

-- 
Jens Axboe