* [PATCH v2] make ioengine specific command line options work
@ 2013-10-09 14:58 Akinobu Mita
2013-10-09 15:32 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Akinobu Mita @ 2013-10-09 14:58 UTC (permalink / raw)
To: fio; +Cc: Akinobu Mita
If the ioengine specific parameter is given on the command line,
unrelated value in thread_data.o will be corrupted unexpectedly.
Specifically, if libaio specific parameter userspace_reap is given
on the command line, thread_data.o.description will be set to 1.
This fixes it by passing the correct pointer of ioengine specific
options to the command line parser.
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
---
* v2
- Update commit log to clarify that this problem only happens with the
command line options.
options.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/options.c b/options.c
index 4b91f52..f26ff77 100644
--- a/options.c
+++ b/options.c
@@ -3603,7 +3603,7 @@ int fio_cmd_option_parse(struct thread_data *td, const char *opt, char *val)
int fio_cmd_ioengine_option_parse(struct thread_data *td, const char *opt,
char *val)
{
- return parse_cmd_option(opt, val, td->io_ops->options, td);
+ return parse_cmd_option(opt, val, td->io_ops->options, td->eo);
}
void fio_fill_default_options(struct thread_data *td)
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v2] make ioengine specific command line options work
2013-10-09 14:58 [PATCH v2] make ioengine specific command line options work Akinobu Mita
@ 2013-10-09 15:32 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2013-10-09 15:32 UTC (permalink / raw)
To: Akinobu Mita, fio
On 10/09/2013 08:58 AM, Akinobu Mita wrote:
> If the ioengine specific parameter is given on the command line,
> unrelated value in thread_data.o will be corrupted unexpectedly.
> Specifically, if libaio specific parameter userspace_reap is given
> on the command line, thread_data.o.description will be set to 1.
>
> This fixes it by passing the correct pointer of ioengine specific
> options to the command line parser.
>
> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Thanks, applied!
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-10-09 15:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-09 14:58 [PATCH v2] make ioengine specific command line options work Akinobu Mita
2013-10-09 15:32 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox