Flexible I/O Tester development
 help / color / mirror / Atom feed
* [PATCH] crc/test.c: fix include of time.h
@ 2014-04-30 18:48 Danny Al-Gaaf
  2014-04-30 21:00 ` Jens Axboe
  0 siblings, 1 reply; 4+ messages in thread
From: Danny Al-Gaaf @ 2014-04-30 18:48 UTC (permalink / raw)
  To: fio; +Cc: Daniel Gollub, Danny Al-Gaaf

Replace include of time.h with renamed fio_time.h to fix build.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
---
 crc/test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/crc/test.c b/crc/test.c
index 2cc7c0f..3773b71 100644
--- a/crc/test.c
+++ b/crc/test.c
@@ -4,7 +4,7 @@
 
 #include "../fio.h"
 #include "../gettime.h"
-#include "../time.h"
+#include "../fio_time.h"
 #include "../verify.h"
 
 #include "../crc/md5.h"
-- 
1.8.5.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] crc/test.c: fix include of time.h
  2014-04-30 18:48 [PATCH] crc/test.c: fix include of time.h Danny Al-Gaaf
@ 2014-04-30 21:00 ` Jens Axboe
  2014-04-30 22:00   ` Danny Al-Gaaf
  0 siblings, 1 reply; 4+ messages in thread
From: Jens Axboe @ 2014-04-30 21:00 UTC (permalink / raw)
  To: Danny Al-Gaaf, fio; +Cc: Daniel Gollub, Danny Al-Gaaf

On 04/30/2014 12:48 PM, Danny Al-Gaaf wrote:
> Replace include of time.h with renamed fio_time.h to fix build.

Thanks Danny, applied. Mine still builds fine, for some odd reason...
But it of course needs fixing.

-- 
Jens Axboe



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] crc/test.c: fix include of time.h
  2014-04-30 21:00 ` Jens Axboe
@ 2014-04-30 22:00   ` Danny Al-Gaaf
  2014-05-01  8:05     ` Daniel Gollub
  0 siblings, 1 reply; 4+ messages in thread
From: Danny Al-Gaaf @ 2014-04-30 22:00 UTC (permalink / raw)
  To: Jens Axboe, fio; +Cc: Daniel Gollub

Am 30.04.2014 23:00, schrieb Jens Axboe:
> On 04/30/2014 12:48 PM, Danny Al-Gaaf wrote:
>> Replace include of time.h with renamed fio_time.h to fix build.
> 
> Thanks Danny, applied. Mine still builds fine, for some odd reason...
> But it of course needs fixing.
> 

It seems it was the same strange issue for Daniel.

Regards,

Danny


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] crc/test.c: fix include of time.h
  2014-04-30 22:00   ` Danny Al-Gaaf
@ 2014-05-01  8:05     ` Daniel Gollub
  0 siblings, 0 replies; 4+ messages in thread
From: Daniel Gollub @ 2014-05-01  8:05 UTC (permalink / raw)
  To: Danny Al-Gaaf; +Cc: Jens Axboe, fio

On Thu, 01 May 2014 00:00:07 +0200, Danny Al-Gaaf wrote:
> Am 30.04.2014 23:00, schrieb Jens Axboe:
> > On 04/30/2014 12:48 PM, Danny Al-Gaaf wrote:
> >> Replace include of time.h with renamed fio_time.h to fix build.
> > 
> > Thanks Danny, applied. Mine still builds fine, for some odd
> > reason... But it of course needs fixing.
> > 
> 
> It seems it was the same strange issue for Daniel.

In my case (Ubuntu) the multi-arch packaging of glibc caused this:

[...]
25441 open("crc/../gettime.h", O_RDONLY|O_NOCTTY) = 4
25441 open("crc/../time.h", O_RDONLY|O_NOCTTY) = -1 ENOENT (No such file or directory)
25441 open("/usr/lib/gcc/x86_64-linux-gnu/4.7/include/../time.h", O_RDONLY|O_NOCTTY) = -1 ENOENT (No such file or directory)
25441 open("/usr/local/include/../time.h", O_RDONLY|O_NOCTTY) = -1 ENOENT (No such file or directory)
25441 open("/usr/lib/gcc/x86_64-linux-gnu/4.7/include-fixed/../time.h", O_RDONLY|O_NOCTTY) = -1 ENOENT (No such file or directory)
25441 open("/usr/include/x86_64-linux-gnu/../time.h", O_RDONLY|O_NOCTTY) = 4 
[...]

I guess the same is true for all Debian-based distros doing multi-arch packaging like this.

Thanks Danny for finding this!

Best Regards
Daniel



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-05-01  8:05 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-30 18:48 [PATCH] crc/test.c: fix include of time.h Danny Al-Gaaf
2014-04-30 21:00 ` Jens Axboe
2014-04-30 22:00   ` Danny Al-Gaaf
2014-05-01  8:05     ` Daniel Gollub

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox