* [PATCH] fio: Eliminate compilation warning in ppc
@ 2014-06-16 5:38 Sumanth K
2014-06-16 19:36 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Sumanth K @ 2014-06-16 5:38 UTC (permalink / raw)
To: fio; +Cc: Sumanth K
From: Sumanth K <sumantk2@linux.vnet.ibm.com>
Eliminate compilation warning : 'atb_clocktest' defined but
not used. Function is declared as static in header file. So compiler will
know if they used or not. Just eliminate the warning by #if 0 /unless we do
use it.
Signed-off-by: Sumanth K <sumantk2@linux.vnet.ibm.com>
---
arch/arch-ppc.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arch-ppc.h b/arch/arch-ppc.h
index 0f043bc..d4a080c 100644
--- a/arch/arch-ppc.h
+++ b/arch/arch-ppc.h
@@ -82,6 +82,7 @@ static inline unsigned long long get_cpu_clock(void)
return ret;
}
+#if 0
static void atb_child(void)
{
arch_flags |= ARCH_FLAG_1;
@@ -106,6 +107,7 @@ static void atb_clocktest(void)
arch_flags |= ARCH_FLAG_1;
}
}
+#endif
#define ARCH_HAVE_INIT
extern int tsc_reliable;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fio: Eliminate compilation warning in ppc
2014-06-16 5:38 [PATCH] fio: Eliminate compilation warning in ppc Sumanth K
@ 2014-06-16 19:36 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2014-06-16 19:36 UTC (permalink / raw)
To: Sumanth K, fio; +Cc: Sumanth K
On 06/15/2014 11:38 PM, Sumanth K wrote:
> From: Sumanth K <sumantk2@linux.vnet.ibm.com>
>
> Eliminate compilation warning : 'atb_clocktest' defined but
> not used. Function is declared as static in header file. So compiler will
> know if they used or not. Just eliminate the warning by #if 0 /unless we do
> use it.
Thanks, applied. Arguably the code should just be removed whole sale, as
it'll always reside in the git history for someone to resurrect.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-16 19:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-16 5:38 [PATCH] fio: Eliminate compilation warning in ppc Sumanth K
2014-06-16 19:36 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox