From: Jens Axboe <axboe@kernel.dk>
To: Bruce Cran <bruce@cran.org.uk>,
"fio@vger.kernel.org" <fio@vger.kernel.org>
Subject: Re: fio exits with 0 with some bad job files
Date: Mon, 06 Oct 2014 19:08:18 -0600 [thread overview]
Message-ID: <54333D02.8040702@kernel.dk> (raw)
In-Reply-To: <54333B40.8010800@kernel.dk>
On 2014-10-06 19:00, Jens Axboe wrote:
> On 2014-10-06 16:27, Bruce Cran wrote:
>> If you run fio with --parse-only and a job file such as
>> examples/tiobench-example.fio that's had the semi-colons removed from
>> the first two lines, fio prints an error message but still exits with 0:
>>
>> % ./fio examples/tiobench-example.fio --parse-only
>> fio: option <tiobench like setup, add more fX files between the
>> stonewalls to> outside of [] job section
>> % echo $?
>> 0
>> %
>>
>> I'd have expected it to exit with a non-zero value.
>
> Not too surprising, don't think any of that was really audited. But a
> bug, of course, will look at fixing that up. Is it consistent across any
> error, or did you just notice this particular one?
That particular one was a silly one, affected the non parse-only as
well. It ended up erroring out on no jobs being defined, so this
improves the behavior for that too.
http://git.kernel.dk/?p=fio.git;a=commit;h=0e9c21a29431e43cd73c83c13271ee6e94fe1328
--
Jens Axboe
prev parent reply other threads:[~2014-10-07 1:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-06 22:27 fio exits with 0 with some bad job files Bruce Cran
2014-10-07 1:00 ` Jens Axboe
2014-10-07 1:08 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54333D02.8040702@kernel.dk \
--to=axboe@kernel.dk \
--cc=bruce@cran.org.uk \
--cc=fio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox