* fio exits with 0 with some bad job files
@ 2014-10-06 22:27 Bruce Cran
2014-10-07 1:00 ` Jens Axboe
0 siblings, 1 reply; 3+ messages in thread
From: Bruce Cran @ 2014-10-06 22:27 UTC (permalink / raw)
To: fio@vger.kernel.org
If you run fio with --parse-only and a job file such as
examples/tiobench-example.fio that's had the semi-colons removed from
the first two lines, fio prints an error message but still exits with 0:
% ./fio examples/tiobench-example.fio --parse-only
fio: option <tiobench like setup, add more fX files between the
stonewalls to> outside of [] job section
% echo $?
0
%
I'd have expected it to exit with a non-zero value.
--
Bruce
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: fio exits with 0 with some bad job files
2014-10-06 22:27 fio exits with 0 with some bad job files Bruce Cran
@ 2014-10-07 1:00 ` Jens Axboe
2014-10-07 1:08 ` Jens Axboe
0 siblings, 1 reply; 3+ messages in thread
From: Jens Axboe @ 2014-10-07 1:00 UTC (permalink / raw)
To: Bruce Cran, fio@vger.kernel.org
On 2014-10-06 16:27, Bruce Cran wrote:
> If you run fio with --parse-only and a job file such as
> examples/tiobench-example.fio that's had the semi-colons removed from
> the first two lines, fio prints an error message but still exits with 0:
>
> % ./fio examples/tiobench-example.fio --parse-only
> fio: option <tiobench like setup, add more fX files between the
> stonewalls to> outside of [] job section
> % echo $?
> 0
> %
>
> I'd have expected it to exit with a non-zero value.
Not too surprising, don't think any of that was really audited. But a
bug, of course, will look at fixing that up. Is it consistent across any
error, or did you just notice this particular one?
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: fio exits with 0 with some bad job files
2014-10-07 1:00 ` Jens Axboe
@ 2014-10-07 1:08 ` Jens Axboe
0 siblings, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2014-10-07 1:08 UTC (permalink / raw)
To: Bruce Cran, fio@vger.kernel.org
On 2014-10-06 19:00, Jens Axboe wrote:
> On 2014-10-06 16:27, Bruce Cran wrote:
>> If you run fio with --parse-only and a job file such as
>> examples/tiobench-example.fio that's had the semi-colons removed from
>> the first two lines, fio prints an error message but still exits with 0:
>>
>> % ./fio examples/tiobench-example.fio --parse-only
>> fio: option <tiobench like setup, add more fX files between the
>> stonewalls to> outside of [] job section
>> % echo $?
>> 0
>> %
>>
>> I'd have expected it to exit with a non-zero value.
>
> Not too surprising, don't think any of that was really audited. But a
> bug, of course, will look at fixing that up. Is it consistent across any
> error, or did you just notice this particular one?
That particular one was a silly one, affected the non parse-only as
well. It ended up erroring out on no jobs being defined, so this
improves the behavior for that too.
http://git.kernel.dk/?p=fio.git;a=commit;h=0e9c21a29431e43cd73c83c13271ee6e94fe1328
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-10-07 1:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-06 22:27 fio exits with 0 with some bad job files Bruce Cran
2014-10-07 1:00 ` Jens Axboe
2014-10-07 1:08 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox