From: Jens Axboe <axboe@kernel.dk>
To: Karthick Srinivasachary <karthick@pernixdata.com>
Cc: fio@vger.kernel.org
Subject: Re: Repeat given pattern with buffer_compress_percentage
Date: Thu, 04 Dec 2014 15:41:24 -0700 [thread overview]
Message-ID: <5480E314.4070206@kernel.dk> (raw)
In-Reply-To: <54807D4F.9080207@kernel.dk>
On 12/04/2014 08:27 AM, Jens Axboe wrote:
> On 12/04/2014 12:53 AM, Karthick Srinivasachary wrote:
>> Hi Jens,
>>
>> Thanks for your response and quick fix.. Much appreciated.
>> Tried few things and saw couple issues, summarizing below. Please let
>> me know if I am missing something.
>>
>> 1. Looks like buffer_compress_percentage with verify option is not
>> giving expected compression percentage
>>
>> fio --name=global --rw=write --buffer_compress_percentage=50
>> --name=job1 --filename=/root/test1 --size=100m --refill_buffers
>> --verify=md5
>>
>> lz4 could compress fio data file
>>
>> lz4 /root/test1
>> Compressed 104857600 bytes into 104857715 bytes ==> 100.00%
>
> The verify buffers are filled differently. It will take a bit more code
> juggling to make that honor the buffer_pattern as a fill pattern. I'll
> take a look at it.
Try current -git, should do the right thing for this case now too. And
it works for the buffer content regeneration, when corruption is
detected and verify_dump=1 is set.
--
Jens Axboe
next prev parent reply other threads:[~2014-12-04 22:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-03 18:48 Repeat given pattern with buffer_compress_percentage Karthick Srinivasachary
2014-12-03 19:45 ` Andrey Kuzmin
2014-12-03 19:49 ` Karthick Srinivasachary
2014-12-03 19:52 ` Andrey Kuzmin
2014-12-04 2:42 ` Jens Axboe
2014-12-04 2:49 ` Jens Axboe
2014-12-04 2:58 ` Jens Axboe
2014-12-04 7:53 ` Karthick Srinivasachary
2014-12-04 15:27 ` Jens Axboe
2014-12-04 22:41 ` Jens Axboe [this message]
2014-12-05 7:25 ` Karthick Srinivasachary
2014-12-05 17:02 ` Jens Axboe
2014-12-05 17:20 ` Jens Axboe
2014-12-05 17:46 ` Jens Axboe
2014-12-05 20:06 ` Karthick Srinivasachary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5480E314.4070206@kernel.dk \
--to=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=karthick@pernixdata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox