From: Jens Axboe <axboe@kernel.dk>
To: Bruce Cran <bruce@cran.org.uk>,
"fio@vger.kernel.org" <fio@vger.kernel.org>
Subject: Re: [PATCH] Add Windows ctime_r implementation and empty ioctl.h header
Date: Thu, 07 May 2015 15:06:22 -0600 [thread overview]
Message-ID: <554BD3CE.6090609@kernel.dk> (raw)
In-Reply-To: <554BD378.70209@cran.org.uk>
On 05/07/2015 03:04 PM, Bruce Cran wrote:
> On 5/7/2015 10:59 AM, Jens Axboe wrote:
>> Added. Side note - your email consistently ends up in my gmail spam,
>> for some reason...
>
> Ugh, it's because DMARC doesn't work through mailing lists without
> jumping through hoops. I'll see if I can disable it for specified
> destinations.
This one got through, but probably because it's a reply..
>> What are the linker errors? I'm guessing you need to check and add
>> your OS dependencies to T_OBJS in the Makefile, when targetos is Windows.
>
> Got it - I'd forgotten that the Makefile is still checked in and it's
> not generated by the configure script!
> I've attached a patch which should make the build work a lot better on
> Windows.
Thanks, added.
--
Jens Axboe
next prev parent reply other threads:[~2015-05-07 21:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-07 3:31 [PATCH] Add Windows ctime_r implementation and empty ioctl.h header Bruce Cran
2015-05-07 16:59 ` Jens Axboe
2015-05-07 21:04 ` Bruce Cran
2015-05-07 21:06 ` Jens Axboe [this message]
2015-05-07 21:27 ` Bruce Cran
2015-05-07 21:32 ` Jens Axboe
2015-05-07 22:56 ` Bruce Cran
2015-05-08 0:20 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554BD3CE.6090609@kernel.dk \
--to=axboe@kernel.dk \
--cc=bruce@cran.org.uk \
--cc=fio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox