Wee nit in backend.c

Flexible I/O Tester development
 help / color / mirror / Atom feed

* Wee nit in backend.c
@ 2015-09-04 19:18 Andrey Kuzmin
  2015-09-04 19:23 ` Jens Axboe
  0 siblings, 1 reply; 2+ messages in thread
From: Andrey Kuzmin @ 2015-09-04 19:18 UTC (permalink / raw)
  To: Jens Axboe; +Cc: fio@vger.kernel.org

[-- Attachment #1: Type: text/plain, Size: 377 bytes --]

diff --git a/backend.c b/backend.c
index 80bd361..fec423e 100644
--- a/backend.c
+++ b/backend.c
@@ -539,7 +539,7 @@ sync_done:
                        *ret = ret2;
                break;
        default:
-               assert(ret < 0);
+               assert(*ret < 0);
                td_verror(td, -(*ret), "td_io_queue");
                break;
        }

Regards,
Andrey

[-- Attachment #2: Type: text/html, Size: 518 bytes --]

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: Wee nit in backend.c
  2015-09-04 19:18 Wee nit in backend.c Andrey Kuzmin
@ 2015-09-04 19:23 ` Jens Axboe
  0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2015-09-04 19:23 UTC (permalink / raw)
  To: Andrey Kuzmin; +Cc: fio@vger.kernel.org

On 09/04/2015 01:18 PM, Andrey Kuzmin wrote:
> diff --git a/backend.c b/backend.c
> index 80bd361..fec423e 100644
> --- a/backend.c
> +++ b/backend.c
> @@ -539,7 +539,7 @@ sync_done:
>                          *ret = ret2;
>                  break;
>          default:
> -               assert(ret < 0);
> +               assert(*ret < 0);
>                  td_verror(td, -(*ret), "td_io_queue");
>                  break;
>          }

Good catch, that was broken by e9d512d8e7d2.

-- 
Jens Axboe



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-09-04 19:23 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-04 19:18 Wee nit in backend.c Andrey Kuzmin
2015-09-04 19:23 ` Jens Axboe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox