* [PATCH] engines/http: set FIO_SYNCIO flag
@ 2019-07-09 14:54 vincentfu
2019-07-09 14:55 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: vincentfu @ 2019-07-09 14:54 UTC (permalink / raw)
To: axboe, fio; +Cc: Vincent Fu
From: Vincent Fu <vincent.fu@wdc.com>
This ioengine carries out synchronous operations. So the FIO_SYNCIO flag
needs to be set in order for latencies to be calculated correctly.
Fixes: https://github.com/axboe/fio/issues/797
---
engines/http.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/engines/http.c b/engines/http.c
index a35c0332..275fcab5 100644
--- a/engines/http.c
+++ b/engines/http.c
@@ -642,7 +642,7 @@ static int fio_http_invalidate(struct thread_data *td, struct fio_file *f)
static struct ioengine_ops ioengine = {
.name = "http",
.version = FIO_IOOPS_VERSION,
- .flags = FIO_DISKLESSIO,
+ .flags = FIO_DISKLESSIO | FIO_SYNCIO,
.setup = fio_http_setup,
.queue = fio_http_queue,
.getevents = fio_http_getevents,
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] engines/http: set FIO_SYNCIO flag
2019-07-09 14:54 [PATCH] engines/http: set FIO_SYNCIO flag vincentfu
@ 2019-07-09 14:55 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2019-07-09 14:55 UTC (permalink / raw)
To: vincentfu, fio; +Cc: Vincent Fu
On 7/9/19 8:54 AM, vincentfu@gmail.com wrote:
> From: Vincent Fu <vincent.fu@wdc.com>
>
> This ioengine carries out synchronous operations. So the FIO_SYNCIO flag
> needs to be set in order for latencies to be calculated correctly.
Applied, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-09 14:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-09 14:54 [PATCH] engines/http: set FIO_SYNCIO flag vincentfu
2019-07-09 14:55 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox