one-core-peak.sh

one-core-peak.sh

[Stephen Bates]

Hi All

We are working on measuring one core peak performance and have been
using the one-core-peak.sh script. While the script does what it needs
to do we find it a bit hard to use and not written in an ideal
fashion. We are planning to do a python version which can be done in a
much cleaner and more readable fashion.

Rather than stomping on toes and just sending a patch to replace this
script I wanted to solicit feedback from the original authors and
community that this is acceptable.

Cheers

Stephen

Re: one-core-peak.sh

[Erwan Velu]

Le 06/10/2022 à 23:00, Stephen Bates a écrit :
> Hi All
>
> We are working on measuring one core peak performance and have been
> using the one-core-peak.sh script. While the script does what it needs
> to do we find it a bit hard to use and not written in an ideal
> fashion. We are planning to do a python version which can be done in a
> much cleaner and more readable fashion.
>
> Rather than stomping on toes and just sending a patch to replace this
> script I wanted to solicit feedback from the original authors and
> community that this is acceptable.

Hey,

Thanks for reaching out.

I wrote this tool as a simple helper and though it would be short enough 
to stay in bash.

The bash was clearly a POC more than a solution.

I totally support moving to python3. I can provide help in this.

Erwan,

Re: one-core-peak.sh

[Stephen Bates]

The 10/07/2022 10:31, Erwan Velu wrote:
> Le 06/10/2022 à 23:00, Stephen Bates a écrit :
> > Hi All
> > 
> > We are working on measuring one core peak performance and have been
> > using the one-core-peak.sh script. While the script does what it needs
> > to do we find it a bit hard to use and not written in an ideal
> > fashion. We are planning to do a python version which can be done in a
> > much cleaner and more readable fashion.
> > 
> > Rather than stomping on toes and just sending a patch to replace this
> > script I wanted to solicit feedback from the original authors and
> > community that this is acceptable.
> 
> Hey,
> 
> Thanks for reaching out.
> 
> I wrote this tool as a simple helper and though it would be short enough to
> stay in bash.
> 
> The bash was clearly a POC more than a solution.
> 
> I totally support moving to python3. I can provide help in this.
> 
> Erwan,
>

Hi Erwan

Thanks for responding! I have opened an issue on Jen's GitHub repo [1]. If you or anyone else fancy collaborating on this please reach out to me. We can work on my fork of fio [2] if it suits and then prepare a patchset.

-- 

Cheers

Stephen

[1]: https://github.com/axboe/fio/issues/1476
[2]: https://github.com/sbates130272/fio