From: Jens Axboe <axboe@kernel.dk>
To: vincentfu@gmail.com, fio@vger.kernel.org
Cc: Vincent Fu <vincent.fu@wdc.com>
Subject: Re: [PATCH] smalloc: fix compiler warning
Date: Wed, 31 Jul 2019 15:28:26 -0600 [thread overview]
Message-ID: <d25403dd-bc12-3d6d-356f-e516de79a580@kernel.dk> (raw)
In-Reply-To: <20190731205751.17531-1-vincentfu@gmail.com>
On 7/31/19 2:57 PM, vincentfu@gmail.com wrote:
> From: Vincent Fu <vincent.fu@wdc.com>
>
> firstfree() triggers a warning from the Windows compiler used by
> AppVeyor because it doesn't return a value if the for loop iterates to
> completion. This patch resolves the compiler warning.
>
> AppVeyor Windows build log: https://ci.appveyor.com/project/axboe/fio/builds/26381726
I did this on top, as it removes the need to have that weird assert()
with a return. Also fixes the coding style (mix of tabs and spaces), and
makes it easier to read imho. Please review!
http://git.kernel.dk/cgit/fio/commit/?id=21eabccd000aaa36ff8af2cd0db833e0871ed85b
--
Jens Axboe
prev parent reply other threads:[~2019-07-31 21:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 20:57 [PATCH] smalloc: fix compiler warning vincentfu
2019-07-31 21:17 ` Jens Axboe
2019-07-31 21:28 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d25403dd-bc12-3d6d-356f-e516de79a580@kernel.dk \
--to=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=vincent.fu@wdc.com \
--cc=vincentfu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox