[PATCH] smalloc: fix compiler warning

[PATCH] smalloc: fix compiler warning

[vincentfu]

From: Vincent Fu <vincent.fu@wdc.com>

firstfree() triggers a warning from the Windows compiler used by
AppVeyor because it doesn't return a value if the for loop iterates to
completion. This patch resolves the compiler warning.

AppVeyor Windows build log: https://ci.appveyor.com/project/axboe/fio/builds/26381726
---
 smalloc.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/smalloc.c b/smalloc.c
index c97bcbaa..0d7054a4 100644
--- a/smalloc.c
+++ b/smalloc.c
@@ -347,6 +347,9 @@ static unsigned int firstfree(struct pool *pool)
                         return i;
 
         assert(0);
+
+	/* we will never get here but this fixes a compiler warning */
+	return -1U;
 }
 
 static void *__smalloc_pool(struct pool *pool, size_t size)
-- 
2.17.1

Re: [PATCH] smalloc: fix compiler warning

[Jens Axboe]

On 7/31/19 2:57 PM, vincentfu@gmail.com wrote:
> From: Vincent Fu <vincent.fu@wdc.com>
> 
> firstfree() triggers a warning from the Windows compiler used by
> AppVeyor because it doesn't return a value if the for loop iterates to
> completion. This patch resolves the compiler warning.
> 
> AppVeyor Windows build log: https://ci.appveyor.com/project/axboe/fio/builds/26381726
> ---
>   smalloc.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/smalloc.c b/smalloc.c
> index c97bcbaa..0d7054a4 100644
> --- a/smalloc.c
> +++ b/smalloc.c
> @@ -347,6 +347,9 @@ static unsigned int firstfree(struct pool *pool)
>                           return i;
>   
>           assert(0);
> +
> +	/* we will never get here but this fixes a compiler warning */
> +	return -1U;
>   }

Thanks, a bit ugly (for Windows), but no big deal.

-- 
Jens Axboe

Re: [PATCH] smalloc: fix compiler warning

[Jens Axboe]

On 7/31/19 2:57 PM, vincentfu@gmail.com wrote:
> From: Vincent Fu <vincent.fu@wdc.com>
> 
> firstfree() triggers a warning from the Windows compiler used by
> AppVeyor because it doesn't return a value if the for loop iterates to
> completion. This patch resolves the compiler warning.
> 
> AppVeyor Windows build log: https://ci.appveyor.com/project/axboe/fio/builds/26381726

I did this on top, as it removes the need to have that weird assert()
with a return. Also fixes the coding style (mix of tabs and spaces), and
makes it easier to read imho. Please review!

http://git.kernel.dk/cgit/fio/commit/?id=21eabccd000aaa36ff8af2cd0db833e0871ed85b

-- 
Jens Axboe