From: fdmanana@kernel.org
To: fstests@vger.kernel.org
Cc: Filipe Manana <fdmanana@suse.com>
Subject: [PATCH] fstests: Fix generic/269 failure due to race killing fsstress job
Date: Fri, 13 Nov 2015 16:47:24 +0000 [thread overview]
Message-ID: <1447433244-25894-1-git-send-email-fdmanana@kernel.org> (raw)
From: Filipe Manana <fdmanana@suse.com>
When running the test generic/269 against a fast scratch device (loopback
device backed by a file on tmpfs) I often got a test failure due to the
fact that the fsstress job had already completed before the test attempted
to kill it, producing the following failure output:
generic/269 91s ... - output mismatch (see .../generic/269.out.bad)
--- tests/generic/269.out 2014-11-17 20:59:50.974203000 +0000
+++ /home/fdmanana/git/hub/xfstests/results//generic/269.out.bad 2015-11-13 15:41:59.669893035 +0000
@@ -3,3 +3,4 @@
Run fsstress
Run dd writers in parallel
+./tests/generic/269: line 59: kill: (13417) - No such process
...
(Run 'diff -u tests/generic/269.out .../generic/269.out.bad' to see the entire diff)
So fix this false failure by redirecting the standard output and error
from the kill into the seq file.
Signed-off-by: Filipe Manana <fdmanana@suse.com>
---
tests/generic/269 | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/generic/269 b/tests/generic/269
index fe648b5..0958222 100755
--- a/tests/generic/269
+++ b/tests/generic/269
@@ -56,7 +56,8 @@ _workout()
>> $seqres.full 2>&1
sleep $enospc_time
done
- kill $pid
+ echo "Killing fsstress process..." >> $seqres.full
+ kill $pid >> $seqres.full 2>&1
wait $pid
}
--
2.1.3
reply other threads:[~2015-11-13 16:47 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447433244-25894-1-git-send-email-fdmanana@kernel.org \
--to=fdmanana@kernel.org \
--cc=fdmanana@suse.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox