public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] fstests: Fix generic/269 failure due to race killing fsstress job
@ 2015-11-13 16:47 fdmanana
  0 siblings, 0 replies; only message in thread
From: fdmanana @ 2015-11-13 16:47 UTC (permalink / raw)
  To: fstests; +Cc: Filipe Manana

From: Filipe Manana <fdmanana@suse.com>

When running the test generic/269 against a fast scratch device (loopback
device backed by a file on tmpfs) I often got a test failure due to the
fact that the fsstress job had already completed before the test attempted
to kill it, producing the following failure output:

generic/269 91s ... - output mismatch (see .../generic/269.out.bad)
    --- tests/generic/269.out	2014-11-17 20:59:50.974203000 +0000
    +++ /home/fdmanana/git/hub/xfstests/results//generic/269.out.bad	2015-11-13 15:41:59.669893035 +0000
    @@ -3,3 +3,4 @@
     Run fsstress

     Run dd writers in parallel
    +./tests/generic/269: line 59: kill: (13417) - No such process
    ...
    (Run 'diff -u tests/generic/269.out .../generic/269.out.bad'  to see the entire diff)

So fix this false failure by redirecting the standard output and error
from the kill into the seq file.

Signed-off-by: Filipe Manana <fdmanana@suse.com>
---
 tests/generic/269 | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/generic/269 b/tests/generic/269
index fe648b5..0958222 100755
--- a/tests/generic/269
+++ b/tests/generic/269
@@ -56,7 +56,8 @@ _workout()
 			>> $seqres.full 2>&1
 		sleep $enospc_time
 	done
-	kill $pid
+	echo "Killing fsstress process..." >> $seqres.full
+	kill $pid >> $seqres.full 2>&1
 	wait $pid
 }
 
-- 
2.1.3


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2015-11-13 16:47 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-13 16:47 [PATCH] fstests: Fix generic/269 failure due to race killing fsstress job fdmanana

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox