From: "Theodore Ts'o" <tytso@mit.edu>
To: fstests@vger.kernel.org
Cc: hughd@google.com, Junho Ryu <jayr@google.com>,
Theodore Ts'o <tytso@mit.edu>
Subject: [PATCH 07/13] generic: do not unmount before calling _check_scratch_fs()
Date: Thu, 11 Feb 2016 00:56:16 -0500 [thread overview]
Message-ID: <1455170182-32587-8-git-send-email-tytso@mit.edu> (raw)
In-Reply-To: <1455170182-32587-1-git-send-email-tytso@mit.edu>
From: Junho Ryu <jayr@google.com>
Fix generic/053 so it works on tmpfs by relying on _check_scratch_fs
to unmount before checking the file system and remounting it
afterwards. Many other tests rely on this, and since tmpfs does not
have a file system consistency checker, this allows the test to
succeed because the files don't disappear when the tmpfs file system
is unmounted.
Signed-off-by: Junho Ryu <jayr@google.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
---
tests/generic/053 | 2 --
tests/generic/053.out | 2 --
2 files changed, 4 deletions(-)
diff --git a/tests/generic/053 b/tests/generic/053
index a0e7280..cf46a93 100755
--- a/tests/generic/053
+++ b/tests/generic/053
@@ -81,9 +81,7 @@ list_acls()
echo "acls before repair:"
list_acls
-_do 'unmount $SCRATCH_DEV' '_scratch_unmount'
_do 'repair filesystem' '_check_scratch_fs'
-_do 'mount filesytem' '_scratch_mount'
echo "acls after repair: "
list_acls
diff --git a/tests/generic/053.out b/tests/generic/053.out
index cd71cbb..d57857a 100644
--- a/tests/generic/053.out
+++ b/tests/generic/053.out
@@ -10,9 +10,7 @@ $SCRATCH_MNT/test.4 [u::---,g::r-x,o::rwx]
$SCRATCH_MNT/test.5 [u::---,u:id2:r-x,g::---,m::rwx,o::---]
$SCRATCH_MNT/test.6 [u::rwx,g::r-x,o::r--]
$SCRATCH_MNT/test.7 [u::---,g::---,g:id2:r-x,m::-w-,o::---]
-unmount $SCRATCH_DEV... done
repair filesystem... done
-mount filesytem... done
acls after repair:
$SCRATCH_MNT/test.0 [u::r--,g::rwx,o::rw-]
$SCRATCH_MNT/test.1 [u::r-x,g::---,o::---]
--
2.5.0
next prev parent reply other threads:[~2016-02-11 5:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-11 5:56 [PATCH-v2 00/13] fix up various tmpfs failures Theodore Ts'o
2016-02-11 5:56 ` [PATCH 01/13] check: avoid spurious complaints that tests/$FSTYP/group does not exist Theodore Ts'o
2016-02-11 5:56 ` [PATCH 02/13] common: _scratch_mkfs_sized() for tmpfs Theodore Ts'o
2016-02-11 5:56 ` [PATCH 03/13] generic: use mount point instead of device name Theodore Ts'o
2016-02-11 5:56 ` [PATCH 04/13] generic: remove the generic/125 test Theodore Ts'o
2016-02-12 5:29 ` Eryu Guan
2016-02-11 5:56 ` [PATCH 05/13] generic: add _require_odirect to generic/113 and generic/214 Theodore Ts'o
2016-02-11 5:56 ` [PATCH 06/13] xfstests: do not unmount tmpfs during remount Theodore Ts'o
2016-02-11 5:56 ` Theodore Ts'o [this message]
2016-02-11 5:56 ` [PATCH 08/13] generic: require fiemap for generic/009 Theodore Ts'o
2016-02-11 5:56 ` [PATCH 09/13] xfstests: remove dependency on /proc/partitions for generic/312 Theodore Ts'o
2016-02-11 5:56 ` [PATCH 10/13] xfstests: generic/079 and generic/277 requires chattr, not xattrs Theodore Ts'o
2016-02-11 5:56 ` [PATCH 11/13] xfstests: add executable permission to tests Theodore Ts'o
2016-02-11 5:56 ` [PATCH 12/13] xfstests: increase tmpfs memory size Theodore Ts'o
2016-02-11 5:56 ` [PATCH 13/13] common: remove unneeded mount options for ext4 Theodore Ts'o
2016-02-12 3:57 ` Dave Chinner
2016-02-12 5:41 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455170182-32587-8-git-send-email-tytso@mit.edu \
--to=tytso@mit.edu \
--cc=fstests@vger.kernel.org \
--cc=hughd@google.com \
--cc=jayr@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox