From: Eryu Guan <eguan@redhat.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: fstests@vger.kernel.org, hughd@google.com
Subject: Re: [PATCH 04/13] generic: remove the generic/125 test
Date: Fri, 12 Feb 2016 13:29:37 +0800 [thread overview]
Message-ID: <20160212052937.GC11419@eguan.usersys.redhat.com> (raw)
In-Reply-To: <1455170182-32587-5-git-send-email-tytso@mit.edu>
On Thu, Feb 11, 2016 at 12:56:13AM -0500, Theodore Ts'o wrote:
> Dave Chinner has pointed out this test is largely pointless:
>
> Perhaps one should question whether generic/125 is actually testing
> anything useful in the first place.
>
> i.e. it's writing 16k, then truncating it back to 1000 bytes, then
> reading it with direct IO for 60s to see if it returns the correct
> data for that entire time.
>
> What, exactly, is going to cause that test to fail?
>
> Keep in mind this was ported from a CXFS test, where the metadata
> server did the truncation operation (including the data zeroing),
> but the reads are being done from the client. i.e. it was designed
> to test whether a remote machine is doing a truncate correctly on a
> access shared disk.
>
> IMO, I think we just remove the test, src/trunc.c and src/ftrunc.c
> because it's 60s of testing that doesn't actually provide any value
> to us.
>
> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
> ---
> tests/generic/125 | 68 -----------------------------------------------------
> tests/generic/group | 1 -
> 2 files changed, 69 deletions(-)
> delete mode 100755 tests/generic/125
Also remove 125.out ?
Thanks,
Eryu
next prev parent reply other threads:[~2016-02-12 5:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-11 5:56 [PATCH-v2 00/13] fix up various tmpfs failures Theodore Ts'o
2016-02-11 5:56 ` [PATCH 01/13] check: avoid spurious complaints that tests/$FSTYP/group does not exist Theodore Ts'o
2016-02-11 5:56 ` [PATCH 02/13] common: _scratch_mkfs_sized() for tmpfs Theodore Ts'o
2016-02-11 5:56 ` [PATCH 03/13] generic: use mount point instead of device name Theodore Ts'o
2016-02-11 5:56 ` [PATCH 04/13] generic: remove the generic/125 test Theodore Ts'o
2016-02-12 5:29 ` Eryu Guan [this message]
2016-02-11 5:56 ` [PATCH 05/13] generic: add _require_odirect to generic/113 and generic/214 Theodore Ts'o
2016-02-11 5:56 ` [PATCH 06/13] xfstests: do not unmount tmpfs during remount Theodore Ts'o
2016-02-11 5:56 ` [PATCH 07/13] generic: do not unmount before calling _check_scratch_fs() Theodore Ts'o
2016-02-11 5:56 ` [PATCH 08/13] generic: require fiemap for generic/009 Theodore Ts'o
2016-02-11 5:56 ` [PATCH 09/13] xfstests: remove dependency on /proc/partitions for generic/312 Theodore Ts'o
2016-02-11 5:56 ` [PATCH 10/13] xfstests: generic/079 and generic/277 requires chattr, not xattrs Theodore Ts'o
2016-02-11 5:56 ` [PATCH 11/13] xfstests: add executable permission to tests Theodore Ts'o
2016-02-11 5:56 ` [PATCH 12/13] xfstests: increase tmpfs memory size Theodore Ts'o
2016-02-11 5:56 ` [PATCH 13/13] common: remove unneeded mount options for ext4 Theodore Ts'o
2016-02-12 3:57 ` Dave Chinner
2016-02-12 5:41 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160212052937.GC11419@eguan.usersys.redhat.com \
--to=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=hughd@google.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox