public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: Eryu Guan <eguan@redhat.com>
To: fstests@vger.kernel.org
Cc: Eryu Guan <eguan@redhat.com>
Subject: [PATCH 2/3] generic: test error handling on filesystem shutdown
Date: Tue, 14 Jun 2016 15:53:40 +0800	[thread overview]
Message-ID: <1465890821-4388-2-git-send-email-eguan@redhat.com> (raw)
In-Reply-To: <1465890821-4388-1-git-send-email-eguan@redhat.com>

Test XFS EFI/EFD error handling. Though it's an XFS bug, it can ran on
any filesystem supports shutdown.

This kernel commit fixed a hang on umount in XFS
8d99fe9 xfs: fix efi/efd error handling to avoid fs shutdown hangs

Though this bug is hard to hit, it's still good to have some coverage.

Signed-off-by: Eryu Guan <eguan@redhat.com>
---
 tests/generic/353     | 73 +++++++++++++++++++++++++++++++++++++++++++++++++++
 tests/generic/353.out |  2 ++
 tests/generic/group   |  1 +
 3 files changed, 76 insertions(+)
 create mode 100755 tests/generic/353
 create mode 100644 tests/generic/353.out

diff --git a/tests/generic/353 b/tests/generic/353
new file mode 100755
index 0000000..0516d8a
--- /dev/null
+++ b/tests/generic/353
@@ -0,0 +1,73 @@
+#! /bin/bash
+# FS QA Test 353
+#
+# Test XFS EFI/EFD error handling.
+#
+# This kernel commit fixed a hang on umount in XFS
+# 8d99fe9 xfs: fix efi/efd error handling to avoid fs shutdown hangs
+#
+#-----------------------------------------------------------------------
+# Copyright (c) 2016 Red Hat Inc.  All Rights Reserved.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it would be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write the Free Software Foundation,
+# Inc.,  51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+#-----------------------------------------------------------------------
+#
+
+seq=`basename $0`
+seqres=$RESULT_DIR/$seq
+echo "QA output created by $seq"
+
+here=`pwd`
+tmp=/tmp/$$
+status=1	# failure is the default!
+trap "_cleanup; exit \$status" 0 1 2 3 15
+
+_cleanup()
+{
+	cd /
+	rm -f $tmp.*
+}
+
+# get standard environment, filters and checks
+. ./common/rc
+. ./common/filter
+
+rm -f $seqres.full
+
+# real QA test starts here
+_supported_fs generic
+_supported_os Linux
+_require_scratch
+_require_scratch_shutdown
+
+_scratch_mkfs >>$seqres.full 2>&1
+_scratch_mount
+
+# fsstress load to generate EFI(extent free intention/EFD(extent free done)
+$FSSTRESS_PROG  -d $SCRATCH_MNT/testdir -n 99999 -p 16 -z -f fallocate=1 \
+		-f punch=1 -f creat=1 -f unlink=1 >>$seqres.full 2>&1 &
+sleep 5
+kill $!
+wait
+
+# shutdown filesystem, handle EFI/EFD in error path
+src/godown -f $SCRATCH_MNT
+
+# don't expect umount to hang. mount it again to do log replay and pass fs check
+_scratch_cycle_mount
+
+# success, all done
+echo "Silence is golden"
+status=0
+exit
diff --git a/tests/generic/353.out b/tests/generic/353.out
new file mode 100644
index 0000000..16ba4f1
--- /dev/null
+++ b/tests/generic/353.out
@@ -0,0 +1,2 @@
+QA output created by 353
+Silence is golden
diff --git a/tests/generic/group b/tests/generic/group
index 4b65dcb..0203afa 100644
--- a/tests/generic/group
+++ b/tests/generic/group
@@ -355,3 +355,4 @@
 350 blockdev quick rw
 351 blockdev quick rw
 352 auto quick metadata
+353 auto quick metadata
-- 
1.8.3.1


  reply	other threads:[~2016-06-14  7:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-14  7:53 [PATCH 1/3] generic: test symlink to very long path Eryu Guan
2016-06-14  7:53 ` Eryu Guan [this message]
2016-06-14 11:43   ` [PATCH 2/3] generic: test error handling on filesystem shutdown Brian Foster
2016-06-14 11:54     ` Eryu Guan
2016-06-14  7:53 ` [PATCH 3/3] generic: test remount on I/O errors Eryu Guan
2016-06-14 11:43   ` Brian Foster
2016-06-14 11:43 ` [PATCH 1/3] generic: test symlink to very long path Brian Foster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1465890821-4388-2-git-send-email-eguan@redhat.com \
    --to=eguan@redhat.com \
    --cc=fstests@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox