Re: [PATCH 2/3] generic: test error handling on filesystem shutdown

[Eryu Guan <eguan@redhat.com>]

On Tue, Jun 14, 2016 at 07:43:26AM -0400, Brian Foster wrote:
> On Tue, Jun 14, 2016 at 03:53:40PM +0800, Eryu Guan wrote:
> > Test XFS EFI/EFD error handling. Though it's an XFS bug, it can ran on
> > any filesystem supports shutdown.
> > 
> > This kernel commit fixed a hang on umount in XFS
> > 8d99fe9 xfs: fix efi/efd error handling to avoid fs shutdown hangs
> > 
> > Though this bug is hard to hit, it's still good to have some coverage.
> > 
> > Signed-off-by: Eryu Guan <eguan@redhat.com>
> > ---
> 
> The test looks fine, though I wonder if we already have other tests that
> might reproduce this problem. On a quick look, generic/051, xfs/079 and
> perhaps one or two others look similar to this test.

Just thought this test might be more targeted.

> 
> Have you verified that 1.) this test reproduces the original problem and
> 2.) that some of these other fsstress+godown tests do not (or are not as
> effective)?

I ran this test tens of times, but I was unable to reproduce the
original problem. And I didn't see any hang triggered by other
fsstress+godown tests in my prevous testings. So I call it a "good to
have" test :)

But if we already have the coverage from other tests, I'm fine with
dropping it.

Thanks for the review!

Eryu