* [PATCH 2/3] overlay/013: fix bug in test_upper creation [not found] <1476867153-17368-1-git-send-email-amir73il@gmail.com> @ 2016-10-19 8:52 ` Amir Goldstein 2016-10-19 8:52 ` [PATCH 3/3] overlay/013: adjust test expectation to kernel v4.8 Amir Goldstein 1 sibling, 0 replies; 2+ messages in thread From: Amir Goldstein @ 2016-10-19 8:52 UTC (permalink / raw) To: Miklos Szeredi, Eryu Guan, Xiong Zhou; +Cc: linux-unionfs, fstests test_upper file was supposed to be in upper layer, but it was wrongly created in lower layer. Signed-off-by: Amir Goldstein <amir73il@gmail.com> --- tests/overlay/013 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/overlay/013 b/tests/overlay/013 index 09f3eb1..e92eeec 100755 --- a/tests/overlay/013 +++ b/tests/overlay/013 @@ -59,7 +59,7 @@ upperdir=$SCRATCH_DEV/$OVERLAY_UPPER_DIR mkdir -p $lowerdir mkdir -p $upperdir cp $here/src/t_truncate_self $lowerdir/test_lower -cp $here/src/t_truncate_self $lowerdir/test_upper +cp $here/src/t_truncate_self $upperdir/test_upper _scratch_mount -- 2.7.4 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH 3/3] overlay/013: adjust test expectation to kernel v4.8 [not found] <1476867153-17368-1-git-send-email-amir73il@gmail.com> 2016-10-19 8:52 ` [PATCH 2/3] overlay/013: fix bug in test_upper creation Amir Goldstein @ 2016-10-19 8:52 ` Amir Goldstein 1 sibling, 0 replies; 2+ messages in thread From: Amir Goldstein @ 2016-10-19 8:52 UTC (permalink / raw) To: Miklos Szeredi, Eryu Guan, Xiong Zhou; +Cc: linux-unionfs, fstests Commit 4d0c5ba (vfs: do get_write_access() on upper layer of overlayfs) that was merged for kernel v4.8 changes the behavior of execve+truncate in a subtle way. When file is executed from lower and then truncated, the truncation is allowed, becasue it only affects the size of the copied up file and does not affect the VM mapping of the executed lower file. Signed-off-by: Amir Goldstein <amir73il@gmail.com> --- tests/overlay/013 | 1 - tests/overlay/013.out | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/overlay/013 b/tests/overlay/013 index e92eeec..e99e10a 100755 --- a/tests/overlay/013 +++ b/tests/overlay/013 @@ -69,6 +69,5 @@ $SCRATCH_MNT/test_lower $SCRATCH_MNT/test_upper # success, all done -echo "Silence is golden" status=0 exit diff --git a/tests/overlay/013.out b/tests/overlay/013.out index 3e66423..b2c7cc7 100644 --- a/tests/overlay/013.out +++ b/tests/overlay/013.out @@ -1,2 +1,2 @@ QA output created by 013 -Silence is golden +truncate(test_lower) should have failed -- 2.7.4 ^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-10-19 15:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1476867153-17368-1-git-send-email-amir73il@gmail.com>
2016-10-19 8:52 ` [PATCH 2/3] overlay/013: fix bug in test_upper creation Amir Goldstein
2016-10-19 8:52 ` [PATCH 3/3] overlay/013: adjust test expectation to kernel v4.8 Amir Goldstein
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox