* [PATCH] xfstests-bld: remove redundant listing of GCE images
@ 2016-12-21 18:06 Eric Biggers
2016-12-22 17:13 ` Theodore Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: Eric Biggers @ 2016-12-21 18:06 UTC (permalink / raw)
To: Theodore Ts'o; +Cc: fstests, Eric Biggers
From: Eric Biggers <ebiggers@google.com>
When a GCE image is created, the same information about the new image
was being printed by both 'gcloud compute images create' and 'gcloud
compute images list'. Fix this by removing the call to 'gcloud compute
images list'.
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
kvm-xfstests/test-appliance/gce-create-image | 1 -
1 file changed, 1 deletion(-)
diff --git a/kvm-xfstests/test-appliance/gce-create-image b/kvm-xfstests/test-appliance/gce-create-image
index 005cc8e..830dd5b 100755
--- a/kvm-xfstests/test-appliance/gce-create-image
+++ b/kvm-xfstests/test-appliance/gce-create-image
@@ -138,4 +138,3 @@ gcloud compute --project "$GCE_PROJECT" -q images create "$ROOT_FS-$DATECODE" \
--family "$ROOT_FS"
gcloud compute --project "$GCE_PROJECT" -q disks delete "$BLD_DISK" \
--zone "$GCE_ZONE" >& /dev/null &
-gcloud compute --project "$GCE_PROJECT" -q images list --filter="family=$ROOT_FS"
--
2.8.0.rc3.226.g39d4020
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xfstests-bld: remove redundant listing of GCE images
2016-12-21 18:06 [PATCH] xfstests-bld: remove redundant listing of GCE images Eric Biggers
@ 2016-12-22 17:13 ` Theodore Ts'o
0 siblings, 0 replies; 2+ messages in thread
From: Theodore Ts'o @ 2016-12-22 17:13 UTC (permalink / raw)
To: Eric Biggers; +Cc: fstests, Eric Biggers
On Wed, Dec 21, 2016 at 10:06:32AM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> When a GCE image is created, the same information about the new image
> was being printed by both 'gcloud compute images create' and 'gcloud
> compute images list'. Fix this by removing the call to 'gcloud compute
> images list'.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
This was deliberate; the goal was to remind the image maintainer to
consider whether some of the older images should be GC'ed.
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-12-22 17:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-21 18:06 [PATCH] xfstests-bld: remove redundant listing of GCE images Eric Biggers
2016-12-22 17:13 ` Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox