public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] xfs/288: filter out extra mkfs warning
@ 2017-05-25  8:38 Zorro Lang
  0 siblings, 0 replies; only message in thread
From: Zorro Lang @ 2017-05-25  8:38 UTC (permalink / raw)
  To: fstests

>From xfsprogs v4.7, mkfs.xfs add respecification detection by
commit 9090e18. Then mkfs will fail and return if we run it
as below:

  mkfs.xfs -m crc=1,finobt=1 -m crc=0 ....

Then _scratch_mkfs_xfs can deal with this problem. But for old
xfsprogs ( < v4.7), it replace the first "crc=1" with the second
"crc=0". Then "crc=0,finobt=1" cause a warning, but keep running:

  "warning: finobt not supported without CRC support, disabled."

This extra warning breaks the golden image of xfs/288, so filter
it out in case.

Signed-off-by: Zorro Lang <zlang@redhat.com>
---

V2 changed the commit log to explain upstream xfsprogs has no this
problem.

Thanks,
Zorro

 tests/xfs/288 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/xfs/288 b/tests/xfs/288
index 6266dd8..0635001 100755
--- a/tests/xfs/288
+++ b/tests/xfs/288
@@ -58,7 +58,7 @@ if [ -z "$XFS_MKFS_HAS_NO_META_SUPPORT" ]; then
 	mkfs_opts="-m crc=0"
 fi
 # get block size ($dbsize) from the mkfs output
-_scratch_mkfs_xfs $mkfs_opts | _filter_mkfs 2>$tmp.mkfs >/dev/null
+_scratch_mkfs_xfs $mkfs_opts 2>/dev/null | _filter_mkfs 2>$tmp.mkfs >/dev/null
 . $tmp.mkfs
 
 _scratch_mount
-- 
2.7.4


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2017-05-25  8:38 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-25  8:38 [PATCH v2] xfs/288: filter out extra mkfs warning Zorro Lang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox