public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: Amir Goldstein <amir73il@gmail.com>
To: Eryu Guan <guaneryu@gmail.com>
Cc: Theodore Ts'o <tytso@mit.edu>,
	fstests@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: [PATCH 1/3] generic/459: use xfs_freeze instead of fsfreeze
Date: Mon, 14 May 2018 08:49:49 +0300	[thread overview]
Message-ID: <1526276991-23897-2-git-send-email-amir73il@gmail.com> (raw)
In-Reply-To: <1526276991-23897-1-git-send-email-amir73il@gmail.com>

This is what all other tests use as well as _require_freeze

Signed-off-by: Amir Goldstein <amir73il@gmail.com>
---
 tests/generic/459 | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/generic/459 b/tests/generic/459
index e755cf7..22b8e62 100755
--- a/tests/generic/459
+++ b/tests/generic/459
@@ -113,7 +113,7 @@ $XFS_IO_PROG -f -d -c 'pwrite -b 1m 0 120m' $SCRATCH_MNT/f1 >>$seqres.full 2>&1
 # extended. It is expected, and is only used so xfsaild is triggered to
 # flush AIL items, other filesystems usually get remounted as read-only during
 # the above write process.
-fsfreeze -f $SCRATCH_MNT >>$seqres.full 2>&1 &
+xfs_freeze -f $SCRATCH_MNT >>$seqres.full 2>&1 &
 freezeid=$!
 
 # Wait enough so xfsaild can run
@@ -132,7 +132,7 @@ ret=$?
 #	- The filesystem stays in Read-Write mode, but can be frozen/thawed
 #	  without getting stuck.
 if [ $ret -ne 0 ]; then
-	# fsfreeze failed, filesystem should reject further writes and remount
+	# freeze failed, filesystem should reject further writes and remount
 	# as readonly. Sometimes the previous write process won't trigger
 	# ro-remount, e.g. on ext3/4, do additional touch here to make sure
 	# filesystems see the metadata I/O error.
@@ -148,7 +148,7 @@ if [ $ret -ne 0 ]; then
 else
 	# Try to thaw the filesystem, and complete test if if succeed.
 	# NOTE: This will hang on affected XFS filesystems.
-	fsfreeze -u $SCRATCH_MNT >>$seqres.full 2>&1
+	xfs_freeze -u $SCRATCH_MNT >>$seqres.full 2>&1
 	echo "Test OK"
 fi
 
-- 
2.7.4


  reply	other threads:[~2018-05-14  5:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-14  5:49 [PATCH 0/3] ext4 freeze regression test Amir Goldstein
2018-05-14  5:49 ` Amir Goldstein [this message]
2018-05-14 23:01   ` [PATCH 1/3] generic/459: use xfs_freeze instead of fsfreeze Dave Chinner
2018-05-15  5:25     ` Amir Goldstein
2018-05-15 13:50       ` Amir Goldstein
2018-05-16  0:47         ` Dave Chinner
2018-05-17  2:36   ` Eryu Guan
2018-05-14  5:49 ` [PATCH 2/3] fstests: define and use TIMEOUT_PROG Amir Goldstein
2018-05-14  5:49 ` [PATCH 3/3] generic: test first read with freeze right after mount Amir Goldstein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1526276991-23897-2-git-send-email-amir73il@gmail.com \
    --to=amir73il@gmail.com \
    --cc=fstests@vger.kernel.org \
    --cc=guaneryu@gmail.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox