From: Dave Chinner <david@fromorbit.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Eryu Guan <guaneryu@gmail.com>, Theodore Ts'o <tytso@mit.edu>,
fstests <fstests@vger.kernel.org>,
Ext4 <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH 1/3] generic/459: use xfs_freeze instead of fsfreeze
Date: Wed, 16 May 2018 10:47:04 +1000 [thread overview]
Message-ID: <20180516004704.GH10363@dastard> (raw)
In-Reply-To: <CAOQ4uxikFp-GsuhmPHud4QtKrSdojBNAnDB6yOfrG-11GU_jRw@mail.gmail.com>
On Tue, May 15, 2018 at 04:50:04PM +0300, Amir Goldstein wrote:
> On Tue, May 15, 2018 at 8:25 AM, Amir Goldstein <amir73il@gmail.com> wrote:
> > On Tue, May 15, 2018 at 2:01 AM, Dave Chinner <david@fromorbit.com> wrote:
> >> On Mon, May 14, 2018 at 08:49:49AM +0300, Amir Goldstein wrote:
> >>> This is what all other tests use as well as _require_freeze
> >>>
> >>> Signed-off-by: Amir Goldstein <amir73il@gmail.com>
> >>> ---
> [...]
> >>
> >> Shouldn't these all be converted to XFS_FREEZE_PROG w/ a setup call
> >> to export XFS_FREEZE_PROG="`set_prog_path xfs_freeze`"?
> >>
> >
> > Yeh, I suppose I can take this one as part of the "freeze" cleanup.
> >
>
> I looked again and xfs_freeze pattern repeats itself quite often with
> other xfs_* progs, so I guess I'll leave that cleanup for another time...
No worries, just add it to the pile...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2018-05-16 0:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-14 5:49 [PATCH 0/3] ext4 freeze regression test Amir Goldstein
2018-05-14 5:49 ` [PATCH 1/3] generic/459: use xfs_freeze instead of fsfreeze Amir Goldstein
2018-05-14 23:01 ` Dave Chinner
2018-05-15 5:25 ` Amir Goldstein
2018-05-15 13:50 ` Amir Goldstein
2018-05-16 0:47 ` Dave Chinner [this message]
2018-05-17 2:36 ` Eryu Guan
2018-05-14 5:49 ` [PATCH 2/3] fstests: define and use TIMEOUT_PROG Amir Goldstein
2018-05-14 5:49 ` [PATCH 3/3] generic: test first read with freeze right after mount Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180516004704.GH10363@dastard \
--to=david@fromorbit.com \
--cc=amir73il@gmail.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox