From: Anand Jain <anand.jain@oracle.com>
To: Boris Burkov <boris@bur.io>,
linux-btrfs@vger.kernel.org, kernel-team@fb.com,
fstests@vger.kernel.org
Subject: Re: [PATCH] btrfs/316: use rescan wrapper
Date: Thu, 14 Mar 2024 07:22:08 +0530 [thread overview]
Message-ID: <18a7d3ab-1396-49d1-8754-ba17023d6cfb@oracle.com> (raw)
In-Reply-To: <5c2dd52fecbc5ac86068a725875882e3000bc969.1710373423.git.boris@bur.io>
On 3/14/24 05:16, Boris Burkov wrote:
> btrfs/316 is broken on the squota configuration because it uses a raw
> rescan call which fails, instead of using the rescan wrapper. The test
> passes with squota, so run it (instead of requiring rescan) though I
> suspect it isn't the most meaningful test.
>
> Signed-off-by: Boris Burkov <boris@bur.io>
> ---
> tests/btrfs/316 | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/btrfs/316 b/tests/btrfs/316
> index 07a94334a..36fcad7f8 100755
> --- a/tests/btrfs/316
> +++ b/tests/btrfs/316
> @@ -24,7 +24,8 @@ _scratch_mkfs >> $seqres.full
> _scratch_mount
>
> $BTRFS_UTIL_PROG quota enable $SCRATCH_MNT
> -$BTRFS_UTIL_PROG quota rescan -w $SCRATCH_MNT >> $seqres.full
> +#$BTRFS_UTIL_PROG quota rescan -w $SCRATCH_MNT >> $seqres.full
Delete instead, I'll fix this locally.
> +_qgroup_rescan $SCRATCH_MNT >> $seqres.full
>
However, we also need.
_require_qgroup_rescan ??
Could you pls confirm. Thx.
> $BTRFS_UTIL_PROG qgroup create 1/0 $SCRATCH_MNT >> $seqres.full
> $BTRFS_UTIL_PROG subvolume create $SCRATCH_MNT/subv1 >> $seqres.full
next prev parent reply other threads:[~2024-03-14 1:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 23:46 [PATCH] btrfs/277: specify protocol version 3 for verity send Boris Burkov
2024-03-13 23:46 ` [PATCH] btrfs/316: use rescan wrapper Boris Burkov
2024-03-13 23:52 ` Filipe Manana
2024-03-14 1:52 ` Anand Jain [this message]
2024-03-13 23:46 ` [PATCH] btrfs: fix _require_btrfs_mkfs_uuid_option Boris Burkov
2024-03-13 23:50 ` Filipe Manana
2024-03-13 23:53 ` [PATCH] btrfs/277: specify protocol version 3 for verity send Filipe Manana
2024-03-14 9:19 ` Anand Jain
2024-03-14 15:01 ` David Sterba
2024-03-14 16:38 ` Boris Burkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18a7d3ab-1396-49d1-8754-ba17023d6cfb@oracle.com \
--to=anand.jain@oracle.com \
--cc=boris@bur.io \
--cc=fstests@vger.kernel.org \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox