From: Anand Jain <anand.jain@oracle.com>
To: Boris Burkov <boris@bur.io>,
linux-btrfs@vger.kernel.org, kernel-team@fb.com,
fstests@vger.kernel.org
Subject: Re: [PATCH] btrfs/277: specify protocol version 3 for verity send
Date: Thu, 14 Mar 2024 14:49:41 +0530 [thread overview]
Message-ID: <d77511bb-cd9c-4217-ab64-71ee96165666@oracle.com> (raw)
In-Reply-To: <3528774789271f9e46918f8b1d1461dad0e11cc4.1710373423.git.boris@bur.io>
On 3/14/24 05:16, Boris Burkov wrote:
> This test uses btrfs send with fs-verity which relies on protocol
> version 3. The default in progs is version 2, so we need to explicitly
> specify the protocol version. Note that the max protocol version in
> progs is also currently broken (not properly gated by EXPERIMENTAL) so
> that needs fixing as well.
>
> Signed-off-by: Boris Burkov <boris@bur.io>
> ---
> tests/btrfs/277 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/btrfs/277 b/tests/btrfs/277
> index f5684fde1..3898bda4d 100755
> --- a/tests/btrfs/277
> +++ b/tests/btrfs/277
> @@ -84,7 +84,7 @@ _test_send_verity() {
> echo "set subvolume read only"
> $BTRFS_UTIL_PROG property set $subv ro true
> echo "send subvolume"
> - $BTRFS_UTIL_PROG send $subv -f $stream -q >> $seqres.full
> + $BTRFS_UTIL_PROG send $subv -f $stream -q --proto=3 >> $seqres.full
>
> echo "blow away fs"
> _scratch_unmount
As of now, the test fails if v3 support isn't in the Send.
Instead, we need to create _require_btrfs_send_v3() to call _notrun().
Thanks, Anand
next prev parent reply other threads:[~2024-03-14 9:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 23:46 [PATCH] btrfs/277: specify protocol version 3 for verity send Boris Burkov
2024-03-13 23:46 ` [PATCH] btrfs/316: use rescan wrapper Boris Burkov
2024-03-13 23:52 ` Filipe Manana
2024-03-14 1:52 ` Anand Jain
2024-03-13 23:46 ` [PATCH] btrfs: fix _require_btrfs_mkfs_uuid_option Boris Burkov
2024-03-13 23:50 ` Filipe Manana
2024-03-13 23:53 ` [PATCH] btrfs/277: specify protocol version 3 for verity send Filipe Manana
2024-03-14 9:19 ` Anand Jain [this message]
2024-03-14 15:01 ` David Sterba
2024-03-14 16:38 ` Boris Burkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d77511bb-cd9c-4217-ab64-71ee96165666@oracle.com \
--to=anand.jain@oracle.com \
--cc=boris@bur.io \
--cc=fstests@vger.kernel.org \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox