From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH 4/5] generic: add mmap write vs truncate/remap test
Date: Wed, 17 Sep 2014 14:51:57 +1000 [thread overview]
Message-ID: <20140917045157.GI4267@dastard> (raw)
In-Reply-To: <54190ECB.2070900@sandeen.net>
On Tue, Sep 16, 2014 at 11:32:11PM -0500, Eric Sandeen wrote:
> On 9/16/14 8:41 PM, Dave Chinner wrote:
> > This test exposed a problem with mapped writes to the tail page of a
> > file in XFS and potentially ext4. Eric did all the hard work of
> > taking the bug report and generating the reproducable test case
> > on ext4, but I haven't been able to reproduce then problem on ext4.
>
> Hm, not even w/ the last test case below, on the byte boundaries?
Sorry, I forgot to rewrite that once I got the byte boundary test
from you. It does, indeed, fail on ext4 as does the previous
mmap/truncate test:
$ sudo MKFS_OPTIONS="-b 1024" ./check generic/029 generic/03[01]
FSTYP -- ext4
PLATFORM -- Linux/x86_64 test4 3.17.0-rc4-dgc+
MKFS_OPTIONS -- -b 1024 /dev/ram1
MOUNT_OPTIONS -- -o acl,user_xattr /dev/ram1 /mnt/scr
generic/029 2s ... - output mismatch (see /home/dave/src/xfstests-dev/results//generic/029.out.bad)
--- tests/generic/029.out 2014-09-17 10:33:15.000000000 +1000
+++ /home/dave/src/xfstests-dev/results//generic/029.out.bad 2014-09-17 14:50:02.000000000 +1000
@@ -10,7 +10,9 @@
==== Post-Remount ==
00000000 58 58 58 58 58 58 58 58 58 58 58 58 58 58 58 58 |XXXXXXXXXXXXXXXX|
*
-00000800 59 59 59 59 59 59 59 59 59 59 59 59 59 59 59 59 |YYYYYYYYYYYYYYYY|
+00000800 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................|
+*
+00001000 59 59 59 59 59 59 59 59 59 59 59 59 59 59 59 59 |YYYYYYYYYYYYYYYY|
...
(Run 'diff -u tests/generic/029.out /home/dave/src/xfstests-dev/results//generic/029.out.bad' to see the entire diff)
generic/030 1s ... - output mismatch (see /home/dave/src/xfstests-dev/results//generic/030.out.bad)
--- tests/generic/030.out 2014-09-17 11:13:55.000000000 +1000
+++ /home/dave/src/xfstests-dev/results//generic/030.out.bad 2014-09-17 14:50:03.000000000 +1000
@@ -10,7 +10,7 @@
==== Post-Remount ==
00000000 58 58 58 58 58 58 58 58 58 58 58 58 58 58 58 58 |XXXXXXXXXXXXXXXX|
*
-004e6400 59 59 59 59 59 59 59 59 59 59 59 59 59 59 59 59 |YYYYYYYYYYYYYYYY|
+004e6400 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................|
*
004e7000
...
(Run 'diff -u tests/generic/030.out /home/dave/src/xfstests-dev/results//generic/030.out.bad' to see the entire diff)
generic/031 2s ... 2s
Ran: generic/029 generic/030 generic/031
Failures: generic/029 generic/030
Failed 2 of 3 tests
> FWIW, I think I can simplify that one - the repeated ops aren't
> necessary. Probably no need to carry that along if they aren't
> relevant to the bug.
>
> I'll look at this more closely tomorrow, thanks for encapsulating
> this in an xfstest.
Can you send any updates as delta patches to this one?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2014-09-17 4:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-17 1:41 [PATCH 0/5] xfstests: cleanups and new tests Dave Chinner
2014-09-17 1:41 ` [PATCH 1/5] generic: more tests should clean up TESTDIR on success Dave Chinner
2014-09-17 4:17 ` Eric Sandeen
2014-09-17 1:41 ` [PATCH 2/5] check: more tests that shouldn't check the scratch device Dave Chinner
2014-09-17 4:27 ` Eric Sandeen
2014-09-17 1:41 ` [PATCH 3/5] generic: add mmap write vs truncate test Dave Chinner
2014-09-19 19:38 ` Eric Sandeen
2014-09-17 1:41 ` [PATCH 4/5] generic: add mmap write vs truncate/remap test Dave Chinner
2014-09-17 4:32 ` Eric Sandeen
2014-09-17 4:51 ` Dave Chinner [this message]
2014-09-19 19:35 ` [PATCH 4.5/5] generic: tidy up " Eric Sandeen
2014-09-19 19:35 ` [PATCH 4/5] generic: add " Eric Sandeen
2014-09-20 0:17 ` Eric Sandeen
2014-09-20 23:32 ` Dave Chinner
2014-09-17 1:41 ` [PATCH 5/5] generic: add write vs fcollapse test Dave Chinner
2014-09-17 12:40 ` Brian Foster
2014-09-18 1:33 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140917045157.GI4267@dastard \
--to=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox