From: Eric Sandeen <sandeen@sandeen.net>
To: Dave Chinner <david@fromorbit.com>, fstests@vger.kernel.org
Subject: Re: [PATCH 2/5] check: more tests that shouldn't check the scratch device
Date: Tue, 16 Sep 2014 23:27:23 -0500 [thread overview]
Message-ID: <54190DAB.3020500@sandeen.net> (raw)
In-Reply-To: <1410918113-23516-3-git-send-email-david@fromorbit.com>
On 9/16/14 8:41 PM, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> xfs/200 leaves a dirty log as readonly filesystems don't write
> unmount records to mark the log clean.
I wonder if it'd be better to just add a case that sets it RW again
and mounts/unmounts it, so we *can* check it after these gyrations?
But if for some reason you don't want to change the existing test,
this is probably ok too; if so,
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
> ---
> tests/xfs/200 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/xfs/200 b/tests/xfs/200
> index f4db64f..f0c4337 100755
> --- a/tests/xfs/200
> +++ b/tests/xfs/200
> @@ -44,7 +44,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
> _supported_fs xfs
> _supported_os Linux
>
> -_require_scratch
> +_require_scratch_nocheck
>
> _scratch_mkfs_xfs >/dev/null 2>&1
>
>
next prev parent reply other threads:[~2014-09-17 4:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-17 1:41 [PATCH 0/5] xfstests: cleanups and new tests Dave Chinner
2014-09-17 1:41 ` [PATCH 1/5] generic: more tests should clean up TESTDIR on success Dave Chinner
2014-09-17 4:17 ` Eric Sandeen
2014-09-17 1:41 ` [PATCH 2/5] check: more tests that shouldn't check the scratch device Dave Chinner
2014-09-17 4:27 ` Eric Sandeen [this message]
2014-09-17 1:41 ` [PATCH 3/5] generic: add mmap write vs truncate test Dave Chinner
2014-09-19 19:38 ` Eric Sandeen
2014-09-17 1:41 ` [PATCH 4/5] generic: add mmap write vs truncate/remap test Dave Chinner
2014-09-17 4:32 ` Eric Sandeen
2014-09-17 4:51 ` Dave Chinner
2014-09-19 19:35 ` [PATCH 4.5/5] generic: tidy up " Eric Sandeen
2014-09-19 19:35 ` [PATCH 4/5] generic: add " Eric Sandeen
2014-09-20 0:17 ` Eric Sandeen
2014-09-20 23:32 ` Dave Chinner
2014-09-17 1:41 ` [PATCH 5/5] generic: add write vs fcollapse test Dave Chinner
2014-09-17 12:40 ` Brian Foster
2014-09-18 1:33 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54190DAB.3020500@sandeen.net \
--to=sandeen@sandeen.net \
--cc=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox