From: Dave Chinner <david@fromorbit.com>
To: Steve French <smfrench@gmail.com>
Cc: Eryu Guan <eguan@redhat.com>,
fstests@vger.kernel.org,
"linux-cifs@vger.kernel.org" <linux-cifs@vger.kernel.org>
Subject: Re: [PATCH] common: enable tests that require scratch device on CIFS
Date: Thu, 13 Nov 2014 15:58:13 +1100 [thread overview]
Message-ID: <20141113045813.GG28565@dastard> (raw)
In-Reply-To: <CAH2r5mt_fvF1dvmbWPq=TBrXgTiyd-xmMgQjQA7+hqb3=1qWFQ@mail.gmail.com>
On Wed, Nov 12, 2014 at 10:40:35PM -0600, Steve French wrote:
> On Wed, Nov 12, 2014 at 10:27 PM, Dave Chinner <david@fromorbit.com> wrote:
> > On Wed, Nov 12, 2014 at 10:08:34PM -0600, Steve French wrote:
> >> On Wed, Nov 12, 2014 at 9:28 PM, Dave Chinner <david@fromorbit.com> wrote:
> >> > On Wed, Nov 12, 2014 at 05:26:13PM -0600, Steve French wrote:
> >> >> I get newly enabled test 294 passing on cifs mounts to Samba.
> >> >>
> >> >> What is best way to get the mount options passed to the mount of
> >> >> scratch dev so it doesn't prompt for it?
> >> >
> >> > # MOUNT_OPTIONS="-o ...." ./check -g auto
> >>
> >> much better - that worked - thanks
> >>
> >> I had been using TEST_FS_MOUNT_OPTS (so I could have multiple sections
> >> in local.config) rather
> >> than MOUNT_OPTIONS
> >
> > BTW, why aren't you using CIFS_MOUNT_OPTIONS to define the login
> > creds for both the test and scratch devices? That's what it was
> > added for....
>
> When specifying multiple sections in local.config (a common case for us
> is to have one section to run tests with cifs dialect, then run again with
> smb2, then again with smb3 dialect etc.). Pavel had indicated that to do this
> you must use TEST_FS_MOUNT_OPTS instead of CIFS_MOUNT_OPTIONS
> if you have multiple sections. I haven't found a way around this.
Adding CIFS_MOUNT_OPTIONS in each section that requires a
different definition should just work. If it doesn't, then please
fix get_next_config() so it does and post the patch....
-Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2014-11-13 4:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-10 10:59 [PATCH] common: enable tests that require scratch device on CIFS Eryu Guan
2014-11-10 15:32 ` Steve French
2014-11-10 16:03 ` Eryu Guan
2014-11-12 23:26 ` Steve French
2014-11-13 3:28 ` Dave Chinner
2014-11-13 4:08 ` Steve French
2014-11-13 4:27 ` Dave Chinner
2014-11-13 4:40 ` Steve French
2014-11-13 4:58 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141113045813.GG28565@dastard \
--to=david@fromorbit.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox