[PATCH] xfs/293: tighten up checks for documented xfs_io commands

[PATCH] xfs/293: tighten up checks for documented xfs_io commands

[Eric Sandeen]

Some commands (like "zero") are simple words which commonly
occur in the manpage text even if they aren't documented as
commands.

Grep for "   $COMMAND" instead of the bare word, because
the documented commands show up as indented.

This reveals that the "zero" command is not documented yet.
(It catches "help" too, because it's documented differently;
I'll fix that up in the manpage when I add "zero").

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

diff --git a/tests/xfs/293 b/tests/xfs/293
index d1a2853..ade6015 100755
--- a/tests/xfs/293
+++ b/tests/xfs/293
@@ -49,7 +49,7 @@ _supported_os IRIX Linux
 echo "Silence is golden"
 
 for COMMAND in `$XFS_IO_PROG -c help | awk '{print $1}' | grep -v "^Use"`; do
-  man xfs_io | col -b | grep -wq $COMMAND || \
+  man xfs_io | col -b | grep -wq "   $COMMAND" || \
 	echo "$COMMAND not documented in the xfs_io manpage"
 done
 

Re: [PATCH] xfs/293: tighten up checks for documented xfs_io commands

[Eryu Guan]

On Fri, Dec 04, 2015 at 03:18:14PM -0600, Eric Sandeen wrote:
> Some commands (like "zero") are simple words which commonly
> occur in the manpage text even if they aren't documented as
> commands.
> 
> Grep for "   $COMMAND" instead of the bare word, because
> the documented commands show up as indented.
> 
> This reveals that the "zero" command is not documented yet.
> (It catches "help" too, because it's documented differently;
> I'll fix that up in the manpage when I add "zero").
> 
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>

Reviewed-by: Eryu Guan <eguan@redhat.com>

> ---
> 
> diff --git a/tests/xfs/293 b/tests/xfs/293
> index d1a2853..ade6015 100755
> --- a/tests/xfs/293
> +++ b/tests/xfs/293
> @@ -49,7 +49,7 @@ _supported_os IRIX Linux
>  echo "Silence is golden"
>  
>  for COMMAND in `$XFS_IO_PROG -c help | awk '{print $1}' | grep -v "^Use"`; do
> -  man xfs_io | col -b | grep -wq $COMMAND || \
> +  man xfs_io | col -b | grep -wq "   $COMMAND" || \
>  	echo "$COMMAND not documented in the xfs_io manpage"
>  done
>  
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html