From: Eryu Guan <eguan@redhat.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: fstests <fstests@vger.kernel.org>
Subject: Re: [PATCH V2] xfs/242: remove open-coded check for "zero" command
Date: Fri, 11 Dec 2015 17:26:07 +0800 [thread overview]
Message-ID: <20151211092607.GU2535@eguan.usersys.redhat.com> (raw)
In-Reply-To: <56620D66.9070108@redhat.com>
On Fri, Dec 04, 2015 at 04:02:14PM -0600, Eric Sandeen wrote:
> We have helpers for this, no need to open-code it.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Eryu Guan <eguan@redhat.com>
> ---
>
> v2: clarify subject w/ "xfs/242"
>
> diff --git a/tests/xfs/242 b/tests/xfs/242
> index 304e69f..4e1a8b4 100755
> --- a/tests/xfs/242
> +++ b/tests/xfs/242
> @@ -47,14 +47,7 @@ _supported_fs xfs
> _supported_os Linux
> _require_test
>
> -_test_io_zero()
> -{
> - $XFS_IO_PROG -c "zero help" 2>&1 | \
> - grep 'command "zero" not found' > /dev/null
> - echo $?
> -}
> -
> -[ $(_test_io_zero) -eq 0 ] && _notrun "zero command not supported"
> +_require_xfs_io_command "zero"
>
> testfile=$TEST_DIR/242.$$
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2015-12-11 9:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-04 21:06 [PATCH] 242: remove open-coded check for "zero" command Eric Sandeen
2015-12-04 22:02 ` [PATCH V2] xfs/242: " Eric Sandeen
2015-12-11 9:26 ` Eryu Guan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151211092607.GU2535@eguan.usersys.redhat.com \
--to=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox