* [PATCH] 242: remove open-coded check for "zero" command
@ 2015-12-04 21:06 Eric Sandeen
2015-12-04 22:02 ` [PATCH V2] xfs/242: " Eric Sandeen
0 siblings, 1 reply; 3+ messages in thread
From: Eric Sandeen @ 2015-12-04 21:06 UTC (permalink / raw)
To: fstests
We have helpers for this, no need to open-code it.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/tests/xfs/242 b/tests/xfs/242
index 304e69f..4e1a8b4 100755
--- a/tests/xfs/242
+++ b/tests/xfs/242
@@ -47,14 +47,7 @@ _supported_fs xfs
_supported_os Linux
_require_test
-_test_io_zero()
-{
- $XFS_IO_PROG -c "zero help" 2>&1 | \
- grep 'command "zero" not found' > /dev/null
- echo $?
-}
-
-[ $(_test_io_zero) -eq 0 ] && _notrun "zero command not supported"
+_require_xfs_io_command "zero"
testfile=$TEST_DIR/242.$$
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH V2] xfs/242: remove open-coded check for "zero" command
2015-12-04 21:06 [PATCH] 242: remove open-coded check for "zero" command Eric Sandeen
@ 2015-12-04 22:02 ` Eric Sandeen
2015-12-11 9:26 ` Eryu Guan
0 siblings, 1 reply; 3+ messages in thread
From: Eric Sandeen @ 2015-12-04 22:02 UTC (permalink / raw)
To: fstests
We have helpers for this, no need to open-code it.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
v2: clarify subject w/ "xfs/242"
diff --git a/tests/xfs/242 b/tests/xfs/242
index 304e69f..4e1a8b4 100755
--- a/tests/xfs/242
+++ b/tests/xfs/242
@@ -47,14 +47,7 @@ _supported_fs xfs
_supported_os Linux
_require_test
-_test_io_zero()
-{
- $XFS_IO_PROG -c "zero help" 2>&1 | \
- grep 'command "zero" not found' > /dev/null
- echo $?
-}
-
-[ $(_test_io_zero) -eq 0 ] && _notrun "zero command not supported"
+_require_xfs_io_command "zero"
testfile=$TEST_DIR/242.$$
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH V2] xfs/242: remove open-coded check for "zero" command
2015-12-04 22:02 ` [PATCH V2] xfs/242: " Eric Sandeen
@ 2015-12-11 9:26 ` Eryu Guan
0 siblings, 0 replies; 3+ messages in thread
From: Eryu Guan @ 2015-12-11 9:26 UTC (permalink / raw)
To: Eric Sandeen; +Cc: fstests
On Fri, Dec 04, 2015 at 04:02:14PM -0600, Eric Sandeen wrote:
> We have helpers for this, no need to open-code it.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Eryu Guan <eguan@redhat.com>
> ---
>
> v2: clarify subject w/ "xfs/242"
>
> diff --git a/tests/xfs/242 b/tests/xfs/242
> index 304e69f..4e1a8b4 100755
> --- a/tests/xfs/242
> +++ b/tests/xfs/242
> @@ -47,14 +47,7 @@ _supported_fs xfs
> _supported_os Linux
> _require_test
>
> -_test_io_zero()
> -{
> - $XFS_IO_PROG -c "zero help" 2>&1 | \
> - grep 'command "zero" not found' > /dev/null
> - echo $?
> -}
> -
> -[ $(_test_io_zero) -eq 0 ] && _notrun "zero command not supported"
> +_require_xfs_io_command "zero"
>
> testfile=$TEST_DIR/242.$$
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-12-11 9:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-04 21:06 [PATCH] 242: remove open-coded check for "zero" command Eric Sandeen
2015-12-04 22:02 ` [PATCH V2] xfs/242: " Eric Sandeen
2015-12-11 9:26 ` Eryu Guan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox