* Does _need_to_be_root deserve to live?
@ 2016-02-11 3:57 Theodore Ts'o
2016-02-11 9:15 ` Eryu Guan
0 siblings, 1 reply; 2+ messages in thread
From: Theodore Ts'o @ 2016-02-11 3:57 UTC (permalink / raw)
To: fstests
There appear to be a number of tests that need to mount and unmount
scratch or su to $qa_user that don't call the helper _need_to_be_root.
Also, sicne the check script calls _check_filesystems between every
single test, which requires unmounting and remounting the test and/or
scratch file systems, does the _need_to_be_root check make any sense
at all?
And if doesn't make any sense, is it worth it to submitting a patch
that just removes all mention of _need_to_be_root from the tests and
common/rc?
Cheers,
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Does _need_to_be_root deserve to live?
2016-02-11 3:57 Does _need_to_be_root deserve to live? Theodore Ts'o
@ 2016-02-11 9:15 ` Eryu Guan
0 siblings, 0 replies; 2+ messages in thread
From: Eryu Guan @ 2016-02-11 9:15 UTC (permalink / raw)
To: Theodore Ts'o; +Cc: fstests
On Wed, Feb 10, 2016 at 10:57:46PM -0500, Theodore Ts'o wrote:
> There appear to be a number of tests that need to mount and unmount
> scratch or su to $qa_user that don't call the helper _need_to_be_root.
>
> Also, sicne the check script calls _check_filesystems between every
> single test, which requires unmounting and remounting the test and/or
> scratch file systems, does the _need_to_be_root check make any sense
> at all?
>
> And if doesn't make any sense, is it worth it to submitting a patch
> that just removes all mention of _need_to_be_root from the tests and
> common/rc?
I think it's safe to remove all _need_to_be_root calls, because there's
already a user-id check in "check"
346 if [ `id -u` -ne 0 ]
347 then
348 echo "check: QA must be run as root"
349 exit 1
350 fi
Thanks,
Eryu
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-11 9:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-11 3:57 Does _need_to_be_root deserve to live? Theodore Ts'o
2016-02-11 9:15 ` Eryu Guan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox