public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] xfs/299: change variable name from "temp" to "tmp" for typo error
@ 2016-04-14  5:32 Zorro Lang
  2016-04-14  6:49 ` Eryu Guan
  0 siblings, 1 reply; 2+ messages in thread
From: Zorro Lang @ 2016-04-14  5:32 UTC (permalink / raw)
  To: fstests; +Cc: Zorro Lang

In xfs/299, project IDs are in $tmp.projid file. But there's one
line code try to use $temp.projid. Fortunately, it doesn't bring
any problems until now, but if keep using $temp.projid it really
don't make sense.

Signed-off-by: Zorro Lang <zlang@redhat.com>
---

Hi,

When I found xfs/299 run failed, I try to dig into it. Although
I sent a duplicate patch for XFS, but there's another tiny
problem I found when I check xfs/299 failure.

I know this problem is very potty, so if someone is writting
another patch about xfs/299, you can fix this incidentally.

Thanks,
Zorro

 tests/xfs/299 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/xfs/299 b/tests/xfs/299
index 1f61eea..d2670f8 100755
--- a/tests/xfs/299
+++ b/tests/xfs/299
@@ -143,7 +143,7 @@ _exercise()
 	_file_as_id $SCRATCH_MNT/initme $id $type 1024 0
 	echo "ls -l $SCRATCH_MNT" >>$seqres.full
 	ls -l $SCRATCH_MNT >>$seqres.full
-	xfs_quota -D $tmp.projects -P $temp.projid -x \
+	xfs_quota -D $tmp.projects -P $tmp.projid -x \
 		-c "limit -$type bsoft=${bsoft}k bhard=${bhard}k $id" \
 		-c "limit -$type isoft=$isoft ihard=$ihard $id" \
 		$SCRATCH_DEV
-- 
2.5.5


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] xfs/299: change variable name from "temp" to "tmp" for typo error
  2016-04-14  5:32 [PATCH] xfs/299: change variable name from "temp" to "tmp" for typo error Zorro Lang
@ 2016-04-14  6:49 ` Eryu Guan
  0 siblings, 0 replies; 2+ messages in thread
From: Eryu Guan @ 2016-04-14  6:49 UTC (permalink / raw)
  To: Zorro Lang; +Cc: fstests

On Thu, Apr 14, 2016 at 01:32:23PM +0800, Zorro Lang wrote:
> In xfs/299, project IDs are in $tmp.projid file. But there's one
> line code try to use $temp.projid. Fortunately, it doesn't bring
> any problems until now, but if keep using $temp.projid it really
> don't make sense.
> 
> Signed-off-by: Zorro Lang <zlang@redhat.com>

Reviewed-by: Eryu Guan <eguan@redhat.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-04-14  6:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-14  5:32 [PATCH] xfs/299: change variable name from "temp" to "tmp" for typo error Zorro Lang
2016-04-14  6:49 ` Eryu Guan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox