* [PATCH] exclude dmerror tests with mount -o dax
@ 2016-05-19 21:12 Eric Sandeen
2016-05-20 14:41 ` Jeff Moyer
2016-05-23 14:59 ` Christoph Hellwig
0 siblings, 2 replies; 3+ messages in thread
From: Eric Sandeen @ 2016-05-19 21:12 UTC (permalink / raw)
To: fstests
Same as we do for dm flakey. dm can't do dax.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/common/dmerror b/common/dmerror
index 004530d..42c075e 100644
--- a/common/dmerror
+++ b/common/dmerror
@@ -18,6 +18,11 @@
#
# common functions for setting up and tearing down a dmerror device
+echo $MOUNT_OPTIONS | grep -q dax
+if [ $? -eq 0 ]; then
+ _notrun "Cannot run tests with DAX on dmerror devices"
+fi
+
_dmerror_init()
{
local dm_backing_dev=$SCRATCH_DEV
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] exclude dmerror tests with mount -o dax
2016-05-19 21:12 [PATCH] exclude dmerror tests with mount -o dax Eric Sandeen
@ 2016-05-20 14:41 ` Jeff Moyer
2016-05-23 14:59 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Moyer @ 2016-05-20 14:41 UTC (permalink / raw)
To: Eric Sandeen; +Cc: fstests
Eric Sandeen <sandeen@redhat.com> writes:
> Same as we do for dm flakey. dm can't do dax.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
We'll add support eventually, but for now this makes sense.
Acked-by: Jeff Moyer <jmoyer@redhat.com>
-Jeff
> ---
>
> diff --git a/common/dmerror b/common/dmerror
> index 004530d..42c075e 100644
> --- a/common/dmerror
> +++ b/common/dmerror
> @@ -18,6 +18,11 @@
> #
> # common functions for setting up and tearing down a dmerror device
>
> +echo $MOUNT_OPTIONS | grep -q dax
> +if [ $? -eq 0 ]; then
> + _notrun "Cannot run tests with DAX on dmerror devices"
> +fi
> +
> _dmerror_init()
> {
> local dm_backing_dev=$SCRATCH_DEV
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] exclude dmerror tests with mount -o dax
2016-05-19 21:12 [PATCH] exclude dmerror tests with mount -o dax Eric Sandeen
2016-05-20 14:41 ` Jeff Moyer
@ 2016-05-23 14:59 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2016-05-23 14:59 UTC (permalink / raw)
To: Eric Sandeen; +Cc: fstests
Looks fine,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-05-23 14:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-19 21:12 [PATCH] exclude dmerror tests with mount -o dax Eric Sandeen
2016-05-20 14:41 ` Jeff Moyer
2016-05-23 14:59 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox