From: Eryu Guan <eguan@redhat.com>
To: Jan Tulak <jtulak@redhat.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH v3] xfstests: Fix installation for extended
Date: Fri, 1 Jul 2016 00:21:08 +0800 [thread overview]
Message-ID: <20160630162107.GJ23649@eguan.usersys.redhat.com> (raw)
In-Reply-To: <CACj3i722hDncFLkN-eZGPPCZ4gSQifwnVX5wpWr_d7dMh5-oOQ@mail.gmail.com>
On Thu, Jun 30, 2016 at 06:08:09PM +0200, Jan Tulak wrote:
> On Thu, Jun 30, 2016 at 6:06 PM, Jan Tulak <jtulak@redhat.com> wrote:
> > xfstests supports extended test names like 314-foo-bar, but installation of
> > these tests was skipped (not matching a regexp). So this patch fixes the
> > makefiles in tests/xfs/.
> >
> > This change will have to be repeated later for other directories, as adding it
> > now everywhere would cause make install to fail if no such extended name is
> > present in the dir.
> >
> > Signed-off-by: Jan Tulak <jtulak@redhat.com>
> > ---
> > UPDATE:
> > Let it be just in tests/xfs/.
> >
> > NOTE: if tested without at first merging my 400-input-valiation test, make
> > install will fail again. :-)
> >
> > Signed-off-by: Jan Tulak <jtulak@redhat.com>
> > ---
> > tests/xfs/Makefile | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/tests/xfs/Makefile b/tests/xfs/Makefile
> > index db94be0..e9b98a3 100644
> > --- a/tests/xfs/Makefile
> > +++ b/tests/xfs/Makefile
> > @@ -13,8 +13,10 @@ include $(BUILDRULES)
> > install:
> > $(INSTALL) -m 755 -d $(TARGET_DIR)
> > $(INSTALL) -m 755 [0-9]?? $(TARGET_DIR)
> > + $(INSTALL) -m 755 [0-9]??-* $(TARGET_DIR)
> > $(INSTALL) -m 644 group $(TARGET_DIR)
> > $(INSTALL) -m 644 [0-9]??.* $(TARGET_DIR)
> > + $(INSTALL) -m 644 [0-9]??-*.* $(TARGET_DIR)
> >
> > # Nothing.
> > install-dev install-lib:
> > --
> > 2.5.5
> >
>
> Ah, I'm sorry, I cut "names" from $SUBJ. Should be "Extended names",
> but I think it is not worth of a fixing patch...
I queued it up with the summary fixed :)
Eryu
next prev parent reply other threads:[~2016-06-30 16:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 14:57 [PATCH] xfstests: Fix installation for extended names Jan Tulak
2016-06-30 3:38 ` Eryu Guan
2016-06-30 8:32 ` Jan Tulak
2016-06-30 8:35 ` [PATCH v2] " Jan Tulak
2016-06-30 13:33 ` Eryu Guan
2016-06-30 15:19 ` Jan Tulak
2016-06-30 15:35 ` Eryu Guan
2016-06-30 16:06 ` [PATCH v3] xfstests: Fix installation for extended Jan Tulak
2016-06-30 16:08 ` Jan Tulak
2016-06-30 16:21 ` Eryu Guan [this message]
2016-07-01 1:16 ` Dave Chinner
2016-07-01 15:51 ` Jan Tulak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160630162107.GJ23649@eguan.usersys.redhat.com \
--to=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=jtulak@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox